Merge lp:~rpadovani/ubuntu-calculator-app/setKeyboardPosition into lp:ubuntu-calculator-app

Proposed by Riccardo Padovani
Status: Merged
Merged at revision: 18
Proposed branch: lp:~rpadovani/ubuntu-calculator-app/setKeyboardPosition
Merge into: lp:ubuntu-calculator-app
Diff against target: 36 lines (+9/-2)
1 file modified
app/ubuntu-calculator-app.qml (+9/-2)
To merge this branch: bzr merge lp:~rpadovani/ubuntu-calculator-app/setKeyboardPosition
Reviewer Review Type Date Requested Status
Bartosz Kosiorek Approve
Review via email: mp+243348@code.launchpad.net

Commit message

Set the inverse order for the listview, so we can set the keyboard position to bottom

Description of the change

Set the inverse order for the listview, so we can set the keyboard position to bottom

To post a comment you must log in.
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

It is working for me perfeclty.

Thanks Riccardo !

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/ubuntu-calculator-app.qml'
--- app/ubuntu-calculator-app.qml 2014-11-28 20:54:49 +0000
+++ app/ubuntu-calculator-app.qml 2014-12-02 00:49:19 +0000
@@ -221,7 +221,7 @@
221 return;221 return;
222 }222 }
223223
224 historyModel.append({"formulaToDisplay":returnFormulaToDisplay(longFormula), "result":displayedInputText});224 historyModel.insert(0, {"formulaToDisplay":returnFormulaToDisplay(longFormula), "result":displayedInputText});
225 longFormula = result;225 longFormula = result;
226 shortFormula = result;226 shortFormula = result;
227 numberOfOpenedBrackets = 0;227 numberOfOpenedBrackets = 0;
@@ -236,7 +236,14 @@
236 ListView {236 ListView {
237 id: formulaView237 id: formulaView
238 anchors.fill: parent238 anchors.fill: parent
239 boundsBehavior: Flickable.StopAtBounds
239 clip: true240 clip: true
241 currentIndex: -1;
242 focus: true
243 snapMode: ListView.SnapToItem
244 // We need to set a bottomToTop direction because we want the listview starts from bottom on load
245 // and we set the position of the keyboard to bottom
246 verticalLayoutDirection: ListView.BottomToTop
240247
241 model: historyModel248 model: historyModel
242249
@@ -244,7 +251,7 @@
244 width: parent.width251 width: parent.width
245 }252 }
246253
247 footer: Column {254 header: Column {
248 width: parent.width255 width: parent.width
249256
250 Text {257 Text {

Subscribers

People subscribed via source and target branches