Code review comment for lp:~rpadovani/ubuntu-calculator-app/delegateImprovement141203

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

> Instead of storing text to display, we should store formula. It will allow us to edit calculations.

Done

> We could also consider (for performance reasons) to store both "formula" and "text to display". But it needs to be tested on device/phone.

I think we could address that in another branch

> During run the warning : "ShaderEffect: Property 'source' is not assigned a valid texture provider (QQuickImage*)." is displayed.

I'm investigating on this. Anyway, I think could be addressed in another branch because it's only a warning

> There is an issue with formula, which exceed screen width. Currently it is not possible scroll it, and check what it contains. Maybe we should contact with User Interface team?

Yes, as soon as this branch is merged I create a click package and send it to gventuri of Design team

> In my opinion equation mark should be the same size as formula.

Done

> Please update "pot" and resolve conflict in "app/ubuntu-calculator-app.qml"

Done

> Can we just increase "spacing" to "spacing: units.gu(3)"?

The result is a bit different, I prefer this one because is smaller, but if you want I can modify it

« Back to merge proposal