Merge lp:~rpadovani/ubuntu-calculator-app/1207679 into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Riccardo Padovani
Status: Merged
Approved by: David Planella
Approved revision: 122
Merged at revision: 126
Proposed branch: lp:~rpadovani/ubuntu-calculator-app/1207679
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 73 lines (+15/-3)
2 files modified
Simple/CalcLabel.qml (+9/-3)
Simple/Screen.qml (+6/-0)
To merge this branch: bzr merge lp:~rpadovani/ubuntu-calculator-app/1207679
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Mihir Soni Approve
Review via email: mp+179189@code.launchpad.net

Commit message

Fixed #1207679 "Pencils appear before calculations are made"

Description of the change

Fixed #1207679 "Pencils appear before calculations are made"

To post a comment you must log in.
120. By Riccardo Padovani

Resolved conflict

121. By Riccardo Padovani

Fixed typo

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Hi ,

I am unable to add comment In operands

Try following scenario :-

1. Try any new calculation
2. I am unable to write on any operand.

review: Needs Fixing
122. By Riccardo Padovani

Fix a bug

Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good :) Thank you

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Works well here now, nice work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Simple/CalcLabel.qml'
--- Simple/CalcLabel.qml 2013-08-07 19:48:44 +0000
+++ Simple/CalcLabel.qml 2013-08-08 14:10:49 +0000
@@ -54,13 +54,16 @@
54 Image {54 Image {
55 anchors.verticalCenter: parent.verticalCenter55 anchors.verticalCenter: parent.verticalCenter
56 source: Qt.resolvedUrl("images/edit.png")56 source: Qt.resolvedUrl("images/edit.png")
57 visible: root.numbers || root.operation
57 }58 }
5859
59 MouseArea {60 MouseArea {
60 anchors.fill: parent61 anchors.fill: parent
61 onClicked: {62 onClicked: {
62 numberName.focus = true;63 if (root.numbers || root.operation) {
63 numberName.forceActiveFocus();64 numberName.focus = true;
65 numberName.forceActiveFocus();
66 }
64 }67 }
65 }68 }
66 }69 }
@@ -78,15 +81,18 @@
78 background: Item {}81 background: Item {}
79 }82 }
8083
84 visible: root.numbers || root.operation
85
81 readOnly: labelReadOnly86 readOnly: labelReadOnly
82 text: labelText87 text: labelText
83 color: "#FEFEFE"88 color: "#FEFEFE"
84 onTextChanged: { labelText = numberName.text }89 onTextChanged: { labelText = numberName.text }
85 hasClearButton: false90 hasClearButton: false
91
86 }92 }
8793
88 Image {94 Image {
89 visible: numberName.focus95 visible: numberName.focus && (root.numbers || root.operation)
90 anchors.bottom: parent.bottom96 anchors.bottom: parent.bottom
91 source: Qt.resolvedUrl("images/dot.png")97 source: Qt.resolvedUrl("images/dot.png")
92 fillMode: Image.Tile98 fillMode: Image.Tile
9399
=== modified file 'Simple/Screen.qml'
--- Simple/Screen.qml 2013-08-07 19:48:44 +0000
+++ Simple/Screen.qml 2013-08-08 14:10:49 +0000
@@ -29,6 +29,7 @@
29 transformOrigin: Item.Bottom29 transformOrigin: Item.Bottom
3030
31 property var ops31 property var ops
32 property var pencilVisible: false
32 signal useAnswer(string answerToUse, string formulaData)33 signal useAnswer(string answerToUse, string formulaData)
33 signal labelTextUpdated(int idx, string newText)34 signal labelTextUpdated(int idx, string newText)
34 signal mainLabelUpdated(int idx, string newText)35 signal mainLabelUpdated(int idx, string newText)
@@ -169,6 +170,7 @@
169 id: row170 id: row
170 height: units.gu(4)171 height: units.gu(4)
171 width: parent.width172 width: parent.width
173 visible: !isLastItem || pencilVisible
172 Item {174 Item {
173 id: editIcon175 id: editIcon
174 height: parent.height176 height: parent.height
@@ -245,6 +247,10 @@
245 onLabelTextChanged: {247 onLabelTextChanged: {
246 root.labelTextUpdated(index, labelText)248 root.labelTextUpdated(index, labelText)
247 }249 }
250
251 onNumbersChanged: {
252 pencilVisible = true
253 }
248 }254 }
249 }255 }
250 }256 }

Subscribers

People subscribed via source and target branches