Code review comment for lp:~rpadovani/reminders-app/upgradeToOxide

Revision history for this message
Olivier Tilloy (osomon) wrote :

I don’t think the use of a WebContextDelegateWorker is correct here. If I understand the intent correctly, you want to:

 - remove that WebContextDelegateWorker
 - update the reminders-scripts.js script to use oxide.sendMessage(…) instead of navigator.qt.postMessage(…)
 - add an Oxide.ScriptMessageHandler to the messageHandlers property of the webview to handle the message sent above

See http://bazaar.launchpad.net/~oxide-developers/oxide/oxide.trunk/view/head:/qt/tests/qmltests/api/tst_ScriptMessage.qml for a complete example of how user scripts work in oxide.

« Back to merge proposal