Code review comment for lp:~rpadovani/reminders-app/multiple-accounts

Revision history for this message
Michael Zanetti (mzanetti) wrote :

>
> Ok, I implemented that, but now if accountPreferences.accountToken is not a
> valid token we have an authentication error, because there is no time to
> intercept UserStore.username, it is set after else is executed.
> So I have no idea on how check if accountPreferences.token is not valid.
> This isn't an uncommon user case: login with an account, user removes the
> account from Online Account, accountToken is no more valid.

actually you do have a good point here... I didn't think of that. Maybe your previous version was indeed better. Sorry for that.

Thanks for fixing the rest. Lets hear the other's opinion on where the logout button should be placed.

« Back to merge proposal