Merge lp:~rpadovani/reminders-app/editNotebooksName into lp:reminders-app

[Riccardo Padovani]

Implemented fronted to change notebooks name

Implemented frontend to change notebooks name: long click on a name to change it, as discussed in previous meeting.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:222
http://91.189.93.70:8080/job/reminders-app-ci/484/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1584
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1584/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/180

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/484/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

working!

review: Approve

[Michael Zanetti (mzanetti)]

oops... revoking approval... found an issue:

44 + notebookTitleLabel.text = notebookTitleTextField.text;
45 + notebookTitleLabel.visible = true;

this is not good. you're breaking the binding with this. Why is this needed at all?

review: Needs Information

[Michael Zanetti (mzanetti)]

yep. now we're good

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:223
http://91.189.93.70:8080/job/reminders-app-ci/488/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1739/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1739/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/184

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/488/rebuild

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/242/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1740/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1740/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/134

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/245/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1803/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1803/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/137

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'src/app/qml/components/NotebooksDelegate.qml'
--- src/app/qml/components/NotebooksDelegate.qml	2014-05-12 17:17:07 +0000
+++ src/app/qml/components/NotebooksDelegate.qml	2014-08-29 15:24:03 +0000
@@ -20,6 +20,7 @@
 import QtQuick.Layouts 1.0
 import Ubuntu.Components 0.1
 import Ubuntu.Components.ListItems 0.1
+import Evernote 0.1
 
 Empty {
     id: root
@@ -58,11 +59,40 @@
                 Layout.fillWidth: true
 
                 Label {
+                    id: notebookTitleLabel
                     objectName: 'notebookTitleLabel'
                     text: model.name
                     color: root.notebookColor
                     fontSize: "large"
-                }
+
+                    MouseArea {
+                        onPressAndHold: {
+                            notebookTitleLabel.visible = false;
+                            notebookTitleTextField.forceActiveFocus();
+                        }
+                        anchors.fill: parent
+                        propagateComposedEvents: true
+                    }
+                }
+
+                TextField {
+                    id: notebookTitleTextField
+                    text: model.name
+                    color: root.notebookColor
+                    visible: !notebookTitleLabel.visible
+
+                    InverseMouseArea {
+                        onClicked: {
+                            if (notebookTitleTextField.text) {
+                                notebooks.notebook(index).name = notebookTitleTextField.text;
+                                NotesStore.saveNotebook(notebooks.notebook(index).guid);
+                                notebookTitleLabel.visible = true;
+                            }
+                        }
+                        anchors.fill: parent
+                    }
+                }
+
                 Label {
                     objectName: 'notebookLastUpdatedLabel'
                     text: i18n.tr("Last edited %1").arg(model.lastUpdatedString)