Code review comment for lp:~rpadovani/reminders-app/defaultNotebookLocalStorage

Revision history for this message
Michael Zanetti (mzanetti) wrote :

I don't think we need a second setting for that, instead we can piggypack on the haveLocalUser one. In line 340, haveLocalUser is set to true. We can just add a check before that, like:

if (!haveLocalUser) {
    NotesStore.createNotebook(...)
    haveLocalUser = true;
}

Also, I don't really like the "First Notebook" one. Please use "Default Notebook" or similar.

review: Needs Fixing

« Back to merge proposal