Code review comment for lp:~rpadovani/reminders-app/cameraImprovement

Revision history for this message
Michael Zanetti (mzanetti) wrote :

44 + if(remove(location) != 0 ) {
45 + qDebug() << "Error deleting temporary image";
46 + } else {
47 + qDebug() << "Temporary image deleted";
48 + }

Please change to:

44 + if(remove(location) != 0 ) {
45 + qWarning() << "Error deleting temporary image";
46 + }

That is, only print something if there's an error, and use a qWarning instead of a qDebug there.

Also, please use QFile::remove() instead of cstdio's remove().

====

Apart from that, great job! Works fine.

review: Needs Fixing

« Back to merge proposal