Code review comment for lp:~rpadovani/reminders-app/cameraImprovement

> file:///home/mzanetti/Development/reviews/cameraImprovement/builddir/src/app/q
> ml/ui/CameraComponents/ZoomControl.qml:35: ReferenceError: iconsRotation is
> not defined
> file:///home/mzanetti/Development/reviews/cameraImprovement/builddir/src/app/q
> ml/ui/CameraComponents/ZoomControl.qml:74: ReferenceError: iconsRotation is
> not defined
>

Thanks, I removed rotation of icons but I didn't remove all occurence :/

> On the desktop, the Shoot button doesn't seem to work for some reason.

This is weird, I change the location of the code but it's the same code previous version.
Do you have any error in console? Is the Shoot Icon active (is white or gray?)

> On the phone, I can take a picture, then I get to the "Use it?" screen.
> Pressing "Use it!" there freezes the app.

No problem here on mako. Again, do you have any error on console?

> On the phone, if I open the Camera page, then press the Flash button to turn
> flash on, and then try to shoot a picture, the app freezes.

I'm not able to reproduce that either... I tried with noflash, autoflash and flash. Could you attack output of your terminal, please?

> Do we support torch mode?

Thanks, forgot to remove also this

> Some things don't fit the coding style. E.g.
>
> 52 + anchors.left: parent.left
> 53 + anchors.top: parent.top
> 54 + anchors.bottom: parent.bottom
> 55 + anchors.right: middle.left
> 56 + anchors.topMargin: units.dp(2)
> 57 + anchors.bottomMargin: units.dp(2)
>
> should be anchors { left: parent.left; top: parent.top; ... }

Fixed

> It seems there is also quite a bit of unneeded copied code around... But ok,
> as this is a temporary solution, I guess no point in completely cleaning it
> up.

I tried to remove all possible...