Merge lp:~rpadovani/reminders-app/1385429 into lp:reminders-app

Proposed by Riccardo Padovani
Status: Merged
Approved by: David Planella
Approved revision: 287
Merged at revision: 287
Proposed branch: lp:~rpadovani/reminders-app/1385429
Merge into: lp:reminders-app
Diff against target: 11 lines (+1/-1)
1 file modified
src/app/qml/reminders.qml (+1/-1)
To merge this branch: bzr merge lp:~rpadovani/reminders-app/1385429
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+239611@code.launchpad.net

Commit message

Enabled automatic orientation

Description of the change

After a fast test with dpm, we choose to enable this
There are some bugs, but it worth the change

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

LGTM, it's a huge improvement on the phone. Post-RTM, we should look at the tablet interface.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/qml/reminders.qml'
--- src/app/qml/reminders.qml 2014-10-10 14:15:04 +0000
+++ src/app/qml/reminders.qml 2014-10-24 19:23:45 +0000
@@ -41,7 +41,7 @@
41 This property enables the application to change orientation41 This property enables the application to change orientation
42 when the device is rotated. The default is false.42 when the device is rotated. The default is false.
43 */43 */
44 //automaticOrientation: true44 automaticOrientation: true
4545
46 property bool narrowMode: root.width < units.gu(80)46 property bool narrowMode: root.width < units.gu(80)
4747

Subscribers

People subscribed via source and target branches