Ubuntu Notes app

Merge lp:~rpadovani/reminders-app/1385429 into lp:reminders-app

  1. 1385429
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Merged
Approved by: David Planella
Approved revision: 287
Merged at revision: 287
Proposed branch: lp:~rpadovani/reminders-app/1385429
Merge into: lp:reminders-app
Diff against target: 11 lines (+1/-1)
1 file modified
src/app/qml/reminders.qml (+1/-1)
To merge this branch: bzr merge lp:~rpadovani/reminders-app/1385429
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+239611@code.launchpad.net

Commit message

Enabled automatic orientation

Description of the change

After a fast test with dpm, we choose to enable this
There are some bugs, but it worth the change

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:287
http://91.189.93.70:8080/job/reminders-app-ci/571/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1268
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1268/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/267

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/571/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

LGTM, it's a huge improvement on the phone. Post-RTM, we should look at the tablet interface.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/reminders.qml'
2--- src/app/qml/reminders.qml 2014-10-10 14:15:04 +0000
3+++ src/app/qml/reminders.qml 2014-10-24 19:23:45 +0000
4@@ -41,7 +41,7 @@
5 This property enables the application to change orientation
6 when the device is rotated. The default is false.
7 */
8- //automaticOrientation: true
9+ automaticOrientation: true
10
11 property bool narrowMode: root.width < units.gu(80)
12

Subscribers

People subscribed via source and target branches