Code review comment for lp:~rpadovani/oxide/http-status-code

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

You rock, thanks :-)

Could you please help me understandig what was wrong?

So, as far as I can say, I called the wrong constructor - instead of

OxideQLoadEvent::OxideQLoadEvent(const QUrl& url,
                                 Type type,
                                 bool is_error,
                                 int http_status_code)

I called

OxideQLoadEvent::OxideQLoadEvent(const QUrl& url,
                                 const QUrl& original_url,
                                 int http_status_code)

so, why the compiler didn't warning me about the conversion from Type type to const QUrl& original_url?

« Back to merge proposal