Code review comment for lp:~rpadovani/oxide/http-status-code

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Hi Olivier,
thanks for your feedback.

Sorry for the delay, it has been a busy week!

I followed your suggestions, so I think now it's ok, but it still has problems with test, because every LoadEvent.TypeSucceeded returns -1 in tst_LoadEvent_httpStatusCode.qml, and it's not a code fail, because I updated also tst_WebView_loading.qml and there LoadEvent.TypeSucceeded returns the right status code.

« Back to merge proposal