Merge lp:~rosslagerwall/usb-creator/treeview-height into lp:usb-creator

Proposed by Ross Lagerwall
Status: Merged
Merged at revision: 392
Proposed branch: lp:~rosslagerwall/usb-creator/treeview-height
Merge into: lp:usb-creator
Diff against target: 25 lines (+2/-2)
1 file modified
gui/usbcreator-gtk.ui (+2/-2)
To merge this branch: bzr merge lp:~rosslagerwall/usb-creator/treeview-height
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+93895@code.launchpad.net

Description of the change

Currently the GTK frontend has source and target treeviews whose height is less than a single row. This simply fixes these to make them to be able to fit a couple of rows which looks much better.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Next time please add a ./debian/changelog entry (using e.g. dch tool) and commit using debcommit.
This is a native package to Ubuntu, so we keep a single changelog in ./debian/changelog
Thanks for your contribution.

review: Approve
Revision history for this message
Ross Lagerwall (rosslagerwall) wrote :

Thanks. I didn't realize that that was the policy for native Ubuntu packages.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On 08/06/12 16:56, Ross Lagerwall wrote:
> Thanks. I didn't realize that that was the policy for native Ubuntu packages.
>

Well that is the case in all debian native packages: e.g. dpkg, apt,
lintian, debhelper, etc.

It is also the case (more-or-less) for all the lp:ubuntu/* packaging
branches.

lp:usb-creator appears to be the 'upstream' but it is actually *the*
packaging branch as well. So 'ubuntu distributed development' rules apply.

=)

No worries.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'gui/usbcreator-gtk.ui'
--- gui/usbcreator-gtk.ui 2011-02-15 17:16:21 +0000
+++ gui/usbcreator-gtk.ui 2012-02-20 20:12:17 +0000
@@ -514,9 +514,9 @@
514 <property name="hscrollbar_policy">never</property>514 <property name="hscrollbar_policy">never</property>
515 <property name="vscrollbar_policy">automatic</property>515 <property name="vscrollbar_policy">automatic</property>
516 <property name="shadow_type">in</property>516 <property name="shadow_type">in</property>
517 <property name="height_request">70</property>
517 <child>518 <child>
518 <object class="GtkTreeView" id="source_treeview">519 <object class="GtkTreeView" id="source_treeview">
519 <property name="height_request">50</property>
520 <property name="visible">True</property>520 <property name="visible">True</property>
521 <property name="can_focus">True</property>521 <property name="can_focus">True</property>
522 <property name="headers_clickable">False</property>522 <property name="headers_clickable">False</property>
@@ -612,9 +612,9 @@
612 <property name="hscrollbar_policy">never</property>612 <property name="hscrollbar_policy">never</property>
613 <property name="vscrollbar_policy">automatic</property>613 <property name="vscrollbar_policy">automatic</property>
614 <property name="shadow_type">in</property>614 <property name="shadow_type">in</property>
615 <property name="height_request">70</property>
615 <child>616 <child>
616 <object class="GtkTreeView" id="dest_treeview">617 <object class="GtkTreeView" id="dest_treeview">
617 <property name="height_request">50</property>
618 <property name="visible">True</property>618 <property name="visible">True</property>
619 <property name="can_focus">True</property>619 <property name="can_focus">True</property>
620 <property name="headers_clickable">False</property>620 <property name="headers_clickable">False</property>

Subscribers

People subscribed via source and target branches