Merge lp:~rosslagerwall/usb-creator/treeview-height into lp:usb-creator

Proposed by Ross Lagerwall
Status: Merged
Merged at revision: 392
Proposed branch: lp:~rosslagerwall/usb-creator/treeview-height
Merge into: lp:usb-creator
Diff against target: 25 lines (+2/-2)
1 file modified
gui/usbcreator-gtk.ui (+2/-2)
To merge this branch: bzr merge lp:~rosslagerwall/usb-creator/treeview-height
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+93895@code.launchpad.net

Description of the change

Currently the GTK frontend has source and target treeviews whose height is less than a single row. This simply fixes these to make them to be able to fit a couple of rows which looks much better.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Next time please add a ./debian/changelog entry (using e.g. dch tool) and commit using debcommit.
This is a native package to Ubuntu, so we keep a single changelog in ./debian/changelog
Thanks for your contribution.

review: Approve
Revision history for this message
Ross Lagerwall (rosslagerwall) wrote :

Thanks. I didn't realize that that was the policy for native Ubuntu packages.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On 08/06/12 16:56, Ross Lagerwall wrote:
> Thanks. I didn't realize that that was the policy for native Ubuntu packages.
>

Well that is the case in all debian native packages: e.g. dpkg, apt,
lintian, debhelper, etc.

It is also the case (more-or-less) for all the lp:ubuntu/* packaging
branches.

lp:usb-creator appears to be the 'upstream' but it is actually *the*
packaging branch as well. So 'ubuntu distributed development' rules apply.

=)

No worries.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gui/usbcreator-gtk.ui'
2--- gui/usbcreator-gtk.ui 2011-02-15 17:16:21 +0000
3+++ gui/usbcreator-gtk.ui 2012-02-20 20:12:17 +0000
4@@ -514,9 +514,9 @@
5 <property name="hscrollbar_policy">never</property>
6 <property name="vscrollbar_policy">automatic</property>
7 <property name="shadow_type">in</property>
8+ <property name="height_request">70</property>
9 <child>
10 <object class="GtkTreeView" id="source_treeview">
11- <property name="height_request">50</property>
12 <property name="visible">True</property>
13 <property name="can_focus">True</property>
14 <property name="headers_clickable">False</property>
15@@ -612,9 +612,9 @@
16 <property name="hscrollbar_policy">never</property>
17 <property name="vscrollbar_policy">automatic</property>
18 <property name="shadow_type">in</property>
19+ <property name="height_request">70</property>
20 <child>
21 <object class="GtkTreeView" id="dest_treeview">
22- <property name="height_request">50</property>
23 <property name="visible">True</property>
24 <property name="can_focus">True</property>
25 <property name="headers_clickable">False</property>

Subscribers

People subscribed via source and target branches