Code review comment for lp:~roryj/gala/maskcorners-plugin

Revision history for this message
Danielle Foré (danrabbit) wrote :

So this is pretty pimp. Very subtle. Some things I noticed:

* The little nudge feedback when attempting to move past the last workspace is not masked.
* When you zoom back in from multi-tasking view, you can see the workspace preview is not masked.
* Any radius over 4 is broken

Another question though: Does this plugin need to be shipped with Gala? There's currently no mechanism for enabling and disabling plugins in Gala. Maybe it would be better to ship as a separate package and let the package manager be the plugin manager through the "enhances" attribute.

review: Needs Fixing

« Back to merge proposal