Code review comment for lp:~roman2861/ubuntu-keyboard/ubuntu-keyboard

Revision history for this message
Dmitry (rusdmitry) wrote :

(Requested a merge with a fix for this branch)

I looked at the values for the characters again and there are still some Latin characters that look like Cyrillic ones (or vice versa). They should be Cyrillic though because they are semantically different:

1) There should be a Cyrillic letter 'а' (U+0430) instead of a Latin 'a' (U+0061) (in uppercase as well: U+0410 instead of U+0041);
2) There should be Cyrillic letters 'е' (U+0435), 'ё' (U+0451) instead of Latin letter 'e' (U+0065), Latin letter 'e' with diaeresis (ë - U+00EB) including their uppercase variants (CYRILLIC CAPITAL LETTER IE U+0415, CYRILLIC CAPITAL LETTER IO U+0401).

I also added the RUBLE SIGN U+20BD which is going to be released with an upcoming Unicode Standard 7.0.0 though additional work must be done here to include a glyph for this character in the Ubuntu font.

review: Needs Fixing

« Back to merge proposal