Code review comment for lp:~roignac/ubuntuone-control-panel/close_window_shortcuts

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Hello Vadim!

First of all, thanks a lot for your contribution.
Secondly, I will have to set this branch as Needs Fixing since we have a strict policy about not adding new code without having the matching test suite validating the change.

To run the whole test suite, you can run the command:


At the moment, that command depends on a patched version of twisted that you can find out in our nightlies PPA: ppa:ubuntuone/nightlies.

Let me know if you need any other guidance.
Regards, Natalia.

review: Needs Fixing

« Back to merge proposal