Ubuntu Software Center

Merge lp:~roignac/software-center/bug-738771-summary-unicode into lp:software-center

  1. bug-738771-summary-unicode
  2. Merge into trunk
Proposed by Vadim Rutkovsky
Status: Merged
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp:~roignac/software-center/bug-738771-summary-unicode
Merge into: lp:software-center
Diff against target: 12 lines (+1/-1)
1 file modified
softwarecenter/ui/gtk/appdetailsview_gtk.py (+1/-1)
To merge this branch: bzr merge lp:~roignac/software-center/bug-738771-summary-unicode
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+68972@code.launchpad.net

Description of the change

Summary is being decoded as 'latin-1' instead of 'utf-8' to avoid problems with some .debs. Not sure about possible regressions though

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this branch! I fixed the bug now based on your idea but in a slightly different way. I still set the branch to "merged" as the bug is gone. Thanks again for your help on this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwarecenter/ui/gtk/appdetailsview_gtk.py'
--- softwarecenter/ui/gtk/appdetailsview_gtk.py 2011-07-21 19:30:15 +0000
+++ softwarecenter/ui/gtk/appdetailsview_gtk.py 2011-07-23 20:36:39 +0000
@@ -1231,7 +1231,7 @@
1231 # make title font size fixed as they should look good compared to the 1231 # make title font size fixed as they should look good compared to the
1232 # icon (also fixed).1232 # icon (also fixed).
1233 markup = '<span font_desc="bold 20">%s</span>\n<span font_desc="9">%s</span>'1233 markup = '<span font_desc="bold 20">%s</span>\n<span font_desc="9">%s</span>'
1234 markup = markup % (appname, GObject.markup_escape_text(summary))1234 markup = markup % (appname, GObject.markup_escape_text(summary.decode('latin-1')))
12351235
1236 self.title.set_markup(markup)1236 self.title.set_markup(markup)
1237 self.title.a11y.set_name(appname + '. ' + summary)1237 self.title.a11y.set_name(appname + '. ' + summary)