Code review comment for lp:~rohangarg/ubuntu-seeds/kubuntu.raring

On Thu, Dec 13, 2012 at 02:25:22PM -0000, Rohan Garg wrote:
> --- STRUCTURE 2012-10-18 17:27:39 +0000
> +++ STRUCTURE 2012-12-13 14:24:22 +0000
> @@ -10,5 +10,13 @@
> dvd: ship development supported-common dvd-langsupport
> full: dvd desktop
> supported-desktop-extra: dvd dvd-live
> +
> +# Active
> +active: standard
> +active-ship: ship
> +active-live: active
> +active-ship-live: ship-live
> +
> # make sure supported remains the last entry
> -supported: dvd-live ship-live full supported-desktop-extra
> +supported: dvd-live ship-live full supported-desktop-extra active-ship-live supported-common
> +

Nothing appears to inherit from the active-ship or active-live seeds.
This will cause problems. I suggest adding them to supported along with
active-ship-live.

> --- active 1970-01-01 00:00:00 +0000
> +++ active 2012-12-13 14:24:22 +0000
[...]
> +Task-Metapackage: kubuntu-active
[...]
> --- desktop 2012-11-27 14:00:14 +0000
> +++ desktop 2012-12-13 14:24:22 +0000
[...]
> +Task-Metapackage: kubuntu-desktop
[...]
> --- full 2011-09-01 11:10:10 +0000
> +++ full 2012-12-13 14:24:22 +0000
[...]
> +Task-Metapackage: kubuntu-full

You can delete all these Task-Metapackage lines; they're redundant since
the default construction of SEEDCOLLECTION-SEEDNAME already produces the
right results here.