Code review comment for lp:~rogpeppe/tomb/update-api
Revision history for this message
| Gustavo Niemeyer (niemeyer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
*** Submitted:
tomb: update API
- Rename Fatal and Fatalf to Kill and Killf.
- The Stop error value is gone. Use nil now.
- Err will now return ErrStillRunning if the goroutine isn't dead
yet, which means a nil return reflects an actual nil Kill call.
- Make zero-value of Tomb good to use, and as a consequence, make
Dead and Dying into methods rather than fields.
R=niemeyer
CC=
https:/
https:/