https://codereview.appspot.com/5755055/diff/6003/tomb.go File tomb.go (right):
https://codereview.appspot.com/5755055/diff/6003/tomb.go#newcode106 tomb.go:106: t.init() On 2012/03/06 17:06:55, niemeyer wrote: > init isn't needed here.
Done.
https://codereview.appspot.com/5755055/diff/6003/tomb_test.go File tomb_test.go (right):
https://codereview.appspot.com/5755055/diff/6003/tomb_test.go#newcode19 tomb_test.go:19: // the Kill reason flags the goroutine as dying On 2012/03/06 17:06:55, niemeyer wrote: > s/Kill/nil/
https://codereview.appspot.com/5755055/diff/6003/tomb_test.go#newcode24 tomb_test.go:24: // a non-Kill reason now will override Kill On 2012/03/06 17:06:55, niemeyer wrote: > s/Kill/nil/g
https://codereview.appspot.com/5755055/
« Back to merge proposal
https:/ /codereview. appspot. com/5755055/ diff/6003/ tomb.go
File tomb.go (right):
https:/ /codereview. appspot. com/5755055/ diff/6003/ tomb.go# newcode106
tomb.go:106: t.init()
On 2012/03/06 17:06:55, niemeyer wrote:
> init isn't needed here.
Done.
https:/ /codereview. appspot. com/5755055/ diff/6003/ tomb_test. go
File tomb_test.go (right):
https:/ /codereview. appspot. com/5755055/ diff/6003/ tomb_test. go#newcode19
tomb_test.go:19: // the Kill reason flags the goroutine as dying
On 2012/03/06 17:06:55, niemeyer wrote:
> s/Kill/nil/
Done.
https:/ /codereview. appspot. com/5755055/ diff/6003/ tomb_test. go#newcode24
tomb_test.go:24: // a non-Kill reason now will override Kill
On 2012/03/06 17:06:55, niemeyer wrote:
> s/Kill/nil/g
Done.
https:/ /codereview. appspot. com/5755055/