Code review comment for lp:~rogpeppe/juju-core/mfoord-wrapsingletonworkers

Revision history for this message
Roger Peppe (rogpeppe) wrote :

Reviewers: mp+215035_code.launchpad.net,

Message:
Please take a look.

Description:
cmd/jujud: wrap singular workers

We start the various workers that require only a single
instance to be running via the runner returned by singular.New.

This is awkward to test - we just do a basic sanity check
that the right workers are started through the singular
runner.

https://code.launchpad.net/~rogpeppe/juju-core/mfoord-wrapsingletonworkers/+merge/215035

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/86200043/

Affected files (+113, -15 lines):
   A [revision details]
   M cmd/jujud/machine.go
   M cmd/jujud/machine_test.go

« Back to merge proposal