Code review comment for lp:~rogpeppe/juju-core/479-desired-peer-group

Revision history for this message
Roger Peppe (rogpeppe) wrote :

Please take a look.

https://codereview.appspot.com/49920045/diff/80001/worker/peergrouper/desired.go
File worker/peergrouper/desired.go (right):

https://codereview.appspot.com/49920045/diff/80001/worker/peergrouper/desired.go#newcode38
worker/peergrouper/desired.go:38: func desiredPeerGroup(info
*peerGroupInfo) ([]replicaset.Member, map[*machine]bool, error) {
On 2014/01/13 18:47:15, nate.finch wrote:
> This function is pretty long, would be a little easier to read if it
were broken
> up more, I think.

Yeah, I'd toyed with that idea but not mustered up the necessary energy.

Done; definitely a good idea, thanks.

https://codereview.appspot.com/49920045/diff/80001/worker/peergrouper/desired.go#newcode199
worker/peergrouper/desired.go:199: found = m
On 2014/01/13 18:47:15, nate.finch wrote:
> break here?

Done.

https://codereview.appspot.com/49920045/

« Back to merge proposal