https://codereview.appspot.com/49920045/diff/80001/worker/peergrouper/desired.go#newcode38
worker/peergrouper/desired.go:38: func desiredPeerGroup(info
*peerGroupInfo) ([]replicaset.Member, map[*machine]bool, error) {
On 2014/01/13 18:47:15, nate.finch wrote:
> This function is pretty long, would be a little easier to read if it
were broken
> up more, I think.
Yeah, I'd toyed with that idea but not mustered up the necessary energy.
Please take a look.
https:/ /codereview. appspot. com/49920045/ diff/80001/ worker/ peergrouper/ desired. go peergrouper/ desired. go (right):
File worker/
https:/ /codereview. appspot. com/49920045/ diff/80001/ worker/ peergrouper/ desired. go#newcode38 peergrouper/ desired. go:38: func desiredPeerGrou p(info Member, map[*machine]bool, error) {
worker/
*peerGroupInfo) ([]replicaset.
On 2014/01/13 18:47:15, nate.finch wrote:
> This function is pretty long, would be a little easier to read if it
were broken
> up more, I think.
Yeah, I'd toyed with that idea but not mustered up the necessary energy.
Done; definitely a good idea, thanks.
https:/ /codereview. appspot. com/49920045/ diff/80001/ worker/ peergrouper/ desired. go#newcode199 peergrouper/ desired. go:199: found = m
worker/
On 2014/01/13 18:47:15, nate.finch wrote:
> break here?
Done.
https:/ /codereview. appspot. com/49920045/