Code review comment for lp:~rogpeppe/juju-core/479-desired-peer-group

Revision history for this message
Nate Finch (natefinch) wrote :

LGTM overall. I'd like to see comments on the functions even if they're
not exported... makes it a little clearer what each one is doing.

https://codereview.appspot.com/49920045/diff/80001/worker/peergrouper/desired.go
File worker/peergrouper/desired.go (right):

https://codereview.appspot.com/49920045/diff/80001/worker/peergrouper/desired.go#newcode38
worker/peergrouper/desired.go:38: func desiredPeerGroup(info
*peerGroupInfo) ([]replicaset.Member, map[*machine]bool, error) {
This function is pretty long, would be a little easier to read if it
were broken up more, I think.

https://codereview.appspot.com/49920045/diff/80001/worker/peergrouper/desired.go#newcode199
worker/peergrouper/desired.go:199: found = m
break here?

https://codereview.appspot.com/49920045/

« Back to merge proposal