juju-core

Merge lp:~rogpeppe/juju-core/377-fix-server-error into lp:~go-bot/juju-core/trunk

377-fix-server-error
Merge into trunk

Proposed by Roger Peppe on 2013-08-28

Status:

Merged

Approved by:

Roger Peppe on 2013-08-28

Approved revision:

no longer in the source branch.

Merged at revision:

1727

Proposed branch:

lp:~rogpeppe/juju-core/377-fix-server-error

Merge into:

lp:~go-bot/juju-core/trunk

Diff against target:

66 lines (+23/-3)

2 files modified

state/apiserver/common/errors.go (+13/-2)
state/apiserver/common/errors_test.go (+10/-1)

To merge this branch:

bzr merge lp:~rogpeppe/juju-core/377-fix-server-error

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Juju Engineering		2013-08-28	Pending
Review via email: mp+182562@code.launchpad.net

Commit message

state/apiserver: make ServerError work properly

It didn't work if the error type was non-comparable.

https://codereview.appspot.com/13336043/

Description of the change

state/apiserver: make ServerError work properly

It didn't work if the error type was non-comparable.

https://codereview.appspot.com/13336043/

Revision history for this message

Roger Peppe (rogpeppe) wrote on 2013-08-28:

Reviewers: mp+182562_code.launchpad.net,

Message:
Please take a look.

Description:
state/apiserver: make ServerError work properly

It didn't work if the error type was non-comparable.

https://code.launchpad.net/~rogpeppe/juju-core/377-fix-server-error/+merge/182562

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13336043/

Affected files:
   A [revision details]
   M state/apiserver/common/errors.go
   M state/apiserver/common/errors_test.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20130827122923-qx3dpiw3118bbub2
+New revision: <email address hidden>

Index: state/apiserver/common/errors.go
=== modified file 'state/apiserver/common/errors.go'
--- state/apiserver/common/errors.go 2013-08-06 17:09:11 +0000
+++ state/apiserver/common/errors.go 2013-08-28 08:45:59 +0000
@@ -51,14 +51,24 @@
ErrNotProvisioned: params.CodeNotProvisioned,
}

+func singletonCode(err error) string {
+ // All error types may not be hashable; deal with
+ // that by catching the panic if we try to look up
+ // a non-hashable type.
+ defer func() {
+ recover()
+ }()
+ return singletonErrorCodes[err]
+}
+
  // ServerError returns an error suitable for returning to an API
  // client, with an error code suitable for various kinds of errors
  // generated in packages outside the API.
-func ServerError(err error) *params.Error {
+func ServerError(err error) (apiError *params.Error) {
   if err == nil {
    return nil
   }
- code := singletonErrorCodes[err]
+ code := singletonCode(err)
   switch {
   case code != "":
   case errors.IsUnauthorizedError(err):

Index: state/apiserver/common/errors_test.go
=== renamed file 'state/apiserver/errors_test.go'
=> 'state/apiserver/common/errors_test.go'
--- state/apiserver/errors_test.go 2013-08-19 11:20:02 +0000
+++ state/apiserver/common/errors_test.go 2013-08-28 08:47:28 +0000
@@ -1,7 +1,7 @@
// Copyright 2012, 2013 Canonical Ltd.
// Licensed under the AGPLv3, see LICENCE file for details.

-package apiserver_test
+package common_test

  import (
   stderrors "errors"
@@ -71,10 +71,19 @@
   err: stderrors.New("an error"),
   code: "",
  }, {
+ err: unhashableError{"foo"},
+ code: "",
+}, {
   err: nil,
   code: "",
  }}

+type unhashableError []string
+
+func (err unhashableError) Error() string {
+ return err[0]
+}
+
  func (s *errorsSuite) TestErrorTransform(c *gc.C) {
   for _, t := range errorTransformTests {
    err1 := common.ServerError(t.err)

Reviewers: mp+182562_code.launchpad.net,

Message:
Please take a look.

Description:
state/apiserver: make ServerError work properly

It didn't work if the error type was non-comparable.

https://code.launchpad.net/~rogpeppe/juju-core/377-fix-server-error/+merge/182562

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13336043/

Affected files:
   A [revision details]
   M state/apiserver/common/errors.go
   M state/apiserver/common/errors_test.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details]	2012-01-01 00:00:00 +0000
+++ [revision details]	2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20130827122923-qx3dpiw3118bbub2
+New revision: roger.peppe@canonical.com-20130828084728-ftp6ihw4yt0fzse3

Index: state/apiserver/common/errors.go
=== modified file 'state/apiserver/common/errors.go'
--- state/apiserver/common/errors.go	2013-08-06 17:09:11 +0000
+++ state/apiserver/common/errors.go	2013-08-28 08:45:59 +0000
@@ -51,14 +51,24 @@
  	ErrNotProvisioned:            params.CodeNotProvisioned,
  }

+func singletonCode(err error) string {
+	// All error types may not be hashable; deal with
+	// that by catching the panic if we try to look up
+	// a non-hashable type.
+	defer func() {
+		recover()
+	}()
+	return singletonErrorCodes[err]
+}
+
  // ServerError returns an error suitable for returning to an API
  // client, with an error code suitable for various kinds of errors
  // generated in packages outside the API.
-func ServerError(err error) *params.Error {
+func ServerError(err error) (apiError *params.Error) {
  	if err == nil {
  		return nil
  	}
-	code := singletonErrorCodes[err]
+	code := singletonCode(err)
  	switch {
  	case code != "":
  	case errors.IsUnauthorizedError(err):

Index: state/apiserver/common/errors_test.go
=== renamed file 'state/apiserver/errors_test.go'  
=> 'state/apiserver/common/errors_test.go'
--- state/apiserver/errors_test.go	2013-08-19 11:20:02 +0000
+++ state/apiserver/common/errors_test.go	2013-08-28 08:47:28 +0000
@@ -1,7 +1,7 @@
  // Copyright 2012, 2013 Canonical Ltd.
  // Licensed under the AGPLv3, see LICENCE file for details.

-package apiserver_test
+package common_test

import (
  	stderrors "errors"
@@ -71,10 +71,19 @@
  	err:  stderrors.New("an error"),
  	code: "",
  }, {
+	err:  unhashableError{"foo"},
+	code: "",
+}, {
  	err:  nil,
  	code: "",
  }}

+type unhashableError []string
+
+func (err unhashableError) Error() string {
+	return err[0]
+}
+
  func (s *errorsSuite) TestErrorTransform(c *gc.C) {
  	for _, t := range errorTransformTests {
  		err1 := common.ServerError(t.err)

Revision history for this message

Roger Peppe (rogpeppe) wrote on 2013-08-28:

Please take a look.

https://codereview.appspot.com/13336043/

Revision history for this message

Roger Peppe (rogpeppe) wrote on 2013-08-28:

Please take a look.

https://codereview.appspot.com/13336043/

Revision history for this message

John A Meinel (jameinel) wrote on 2013-08-28:

Thanks for moving the tests.

I have:
https://codereview.appspot.com/13338043

For the other way of fixing this.

I don't really care who wins.

LGTM

https://codereview.appspot.com/13336043/diff/8001/state/apiserver/common/errors.go
File state/apiserver/common/errors.go (right):

https://codereview.appspot.com/13336043/diff/8001/state/apiserver/common/errors.go#newcode68
state/apiserver/common/errors.go:68: func ServerError(err error)
(apiError *params.Error) {
^ I don't think this change adds anything since you are calling to a
different function to do the map lookup.

https://codereview.appspot.com/13336043/

Revision history for this message

Roger Peppe (rogpeppe) wrote on 2013-08-28:

https://codereview.appspot.com/13336043/diff/8001/state/apiserver/common/errors.go
File state/apiserver/common/errors.go (right):

https://codereview.appspot.com/13336043/diff/8001/state/apiserver/common/errors.go#newcode68
state/apiserver/common/errors.go:68: func ServerError(err error)
(apiError *params.Error) {
On 2013/08/28 09:02:40, jameinel wrote:
> ^ I don't think this change adds anything since you are calling to a
different
> function to do the map lookup.

ha, that was a relic of when i had the recovery in this function.
removed.

https://codereview.appspot.com/13336043/

Revision history for this message

Roger Peppe (rogpeppe) wrote on 2013-08-28:

Please take a look.

https://codereview.appspot.com/13336043/

Revision history for this message

Go Bot (go-bot) wrote on 2013-08-28:

Download full text (44.5 KiB)

The attempt to merge lp:~rogpeppe/juju-core/377-fix-server-error into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/agent 0.693s
ok launchpad.net/juju-core/agent/tools 0.215s
ok launchpad.net/juju-core/bzr 6.429s
ok launchpad.net/juju-core/cert 2.239s
ok launchpad.net/juju-core/charm 0.539s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.026s
ok launchpad.net/juju-core/cmd 0.212s
? launchpad.net/juju-core/cmd/builddb [no test files]
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 115.176s
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x62865d]

goroutine 743 [running]:
sync/atomic.CompareAndSwapUint32()
/usr/lib/go/src/pkg/sync/atomic/asm_amd64.s:14 +0xd
sync.(*Mutex).Lock(0x0)
/usr/lib/go/src/pkg/sync/mutex.go:43 +0x35
launchpad.net/tomb.(*Tomb).init(0x0)
/home/tarmac/trees/src/src/launchpad.net/tomb/tomb.go:83 +0x25
launchpad.net/tomb.(*Tomb).Kill(0x0, 0x0, 0x0)
/home/tarmac/trees/src/src/launchpad.net/tomb/tomb.go:135 +0x25
launchpad.net/juju-core/state/api/watcher.(*commonWatcher).Stop(0x0, 0xc2002d1800, 0x0)
/home/tarmac/trees/src/launchpad.net/juju-core/state/api/watcher/watcher.go:103 +0x31
launchpad.net/juju-core/worker.(*notifyWorker).loop(0xc2003fc5c0, 0x0, 0x0)
/home/tarmac/trees/src/launchpad.net/juju-core/worker/notifyworker.go:86 +0x7e
launchpad.net/juju-core/worker.func·002()
/home/tarmac/trees/src/launchpad.net/juju-core/worker/notifyworker.go:53 +0x4e
created by launchpad.net/juju-core/worker.NewNotifyWorker
/home/tarmac/trees/src/launchpad.net/juju-core/worker/notifyworker.go:54 +0xa1

goroutine 1 [chan receive]:
testing.RunTests(0xd998b8, 0x1229700, 0x2, 0x2, 0xc2001af701, ...)
/usr/lib/go/src/pkg/testing/testing.go:434 +0x88e
testing.Main(0xd998b8, 0x1229700, 0x2, 0x2, 0x1233ea0, ...)
/usr/lib/go/src/pkg/testing/testing.go:365 +0x8a
main.main()
launchpad.net/juju-core/cmd/jujud/_test/_testmain.go:45 +0x9a

goroutine 2 [syscall]:

goroutine 5 [chan receive]:
launchpad.net/juju-core/provider/dummy.func·001()
/home/tarmac/trees/src/launchpad.net/juju-core/provider/dummy/environs.go:177 +0x3a
created by launchpad.net/juju-core/provider/dummy.init·1
/home/tarmac/trees/src/launchpad.net/juju-core/provider/dummy/environs.go:179 +0xc1

The attempt to merge lp:~rogpeppe/juju-core/377-fix-server-error into lp:juju-core failed. Below is the output from the failed tests.

ok  	launchpad.net/juju-core/agent	0.693s
ok  	launchpad.net/juju-core/agent/tools	0.215s
ok  	launchpad.net/juju-core/bzr	6.429s
ok  	launchpad.net/juju-core/cert	2.239s
ok  	launchpad.net/juju-core/charm	0.539s
?   	launchpad.net/juju-core/charm/hooks	[no test files]
ok  	launchpad.net/juju-core/cloudinit	0.026s
ok  	launchpad.net/juju-core/cmd	0.212s
?   	launchpad.net/juju-core/cmd/builddb	[no test files]
?   	launchpad.net/juju-core/cmd/charmd	[no test files]
?   	launchpad.net/juju-core/cmd/charmload	[no test files]
ok  	launchpad.net/juju-core/cmd/juju	115.176s
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x62865d]

goroutine 743 [running]:
sync/atomic.CompareAndSwapUint32()
	/usr/lib/go/src/pkg/sync/atomic/asm_amd64.s:14 +0xd
sync.(*Mutex).Lock(0x0)
	/usr/lib/go/src/pkg/sync/mutex.go:43 +0x35
launchpad.net/tomb.(*Tomb).init(0x0)
	/home/tarmac/trees/src/src/launchpad.net/tomb/tomb.go:83 +0x25
launchpad.net/tomb.(*Tomb).Kill(0x0, 0x0, 0x0)
	/home/tarmac/trees/src/src/launchpad.net/tomb/tomb.go:135 +0x25
launchpad.net/juju-core/state/api/watcher.(*commonWatcher).Stop(0x0, 0xc2002d1800, 0x0)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/watcher/watcher.go:103 +0x31
launchpad.net/juju-core/worker.(*notifyWorker).loop(0xc2003fc5c0, 0x0, 0x0)
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/notifyworker.go:86 +0x7e
launchpad.net/juju-core/worker.func·002()
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/notifyworker.go:53 +0x4e
created by launchpad.net/juju-core/worker.NewNotifyWorker
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/notifyworker.go:54 +0xa1

goroutine 1 [chan receive]:
testing.RunTests(0xd998b8, 0x1229700, 0x2, 0x2, 0xc2001af701, ...)
	/usr/lib/go/src/pkg/testing/testing.go:434 +0x88e
testing.Main(0xd998b8, 0x1229700, 0x2, 0x2, 0x1233ea0, ...)
	/usr/lib/go/src/pkg/testing/testing.go:365 +0x8a
main.main()
	launchpad.net/juju-core/cmd/jujud/_test/_testmain.go:45 +0x9a

goroutine 2 [syscall]:

goroutine 5 [chan receive]:
launchpad.net/juju-core/provider/dummy.func·001()
	/home/tarmac/trees/src/launchpad.net/juju-core/provider/dummy/environs.go:177 +0x3a
created by launchpad.net/juju-core/provider/dummy.init·1
	/home/tarmac/trees/src/launchpad.net/juju-core/provider/dummy/environs.go:179 +0xc1

goroutine 7 [chan receive]:
launchpad.net/gocheck.(*suiteRunner).runTest(0xc2004689a0, 0xc20046c3f0, 0xc200697140)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/gocheck.go:771 +0x4f
launchpad.net/gocheck.(*suiteRunner).run(0xc2004689a0, 0xc2001dc280)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/gocheck.go:584 +0x1c5
launchpad.net/gocheck.Run(0xc21fa0, 0xc2001dc280, 0xc20025d340, 0xc200393400)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/run.go:76 +0x47
launchpad.net/gocheck.RunAll(0xc20025d340, 0xc20025d340)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/run.go:68 +0xc2
launchpad.net/gocheck.TestingT(0xc2001af870)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/run.go:56 +0x2a2
launchpad.net/juju-core/testing.MgoTestPackage(0xc2001af870)
	/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:134 +0xcf
launchpad.net/juju-core/cmd/jujud.TestPackage(0xc2001af870)
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/main_test.go:40 +0x149
testing.tRunner(0xc2001af870, 0x1229700)
	/usr/lib/go/src/pkg/testing/testing.go:353 +0x8a
created by testing.RunTests
	/usr/lib/go/src/pkg/testing/testing.go:433 +0x86b

goroutine 134 [syscall]:
syscall.Syscall()
	/usr/lib/go/src/pkg/syscall/asm_linux_amd64.s:16 +0x5
syscall.read(0x7, 0xc200637000, 0x1000, 0x1000, 0x55, ...)
	/usr/lib/go/src/pkg/syscall/zerrors_linux_amd64.go:2337 +0x70
syscall.Read(0x7, 0xc200637000, 0x1000, 0x1000, 0x55, ...)
	/usr/lib/go/src/pkg/syscall/syscall_unix.go:132 +0x5a
os.(*File).read(0xc2003b3da0, 0xc200637000, 0x1000, 0x1000, 0x55, ...)
	/usr/lib/go/src/pkg/os/file_unix.go:174 +0x60
os.(*File).Read(0xc2003b3da0, 0xc200637000, 0x1000, 0x1000, 0x0, ...)
	/usr/lib/go/src/pkg/os/file.go:95 +0x96
bufio.(*Reader).fill(0xc200469000)
	/usr/lib/go/src/pkg/bufio/bufio.go:79 +0x10c
bufio.(*Reader).ReadSlice(0xc200469000, 0xa, 0x0, 0x0, 0x0, ...)
	/usr/lib/go/src/pkg/bufio/bufio.go:262 +0x202
bufio.(*Reader).ReadBytes(0xc200469000, 0x476d0a, 0x0, 0x0, 0x0, ...)
	/usr/lib/go/src/pkg/bufio/bufio.go:343 +0xb7
bufio.(*Reader).ReadString(0xc200469000, 0xa, 0x0, 0x0, 0x0, ...)
	/usr/lib/go/src/pkg/bufio/bufio.go:383 +0x53
launchpad.net/juju-core/testing.readLines(0xc200195f00, 0xc2003b3da0, 0x14, 0xc200195f00, 0xc2003b3da0, ...)
	/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:153 +0xa4
launchpad.net/juju-core/testing.func·005()
	/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:95 +0x72
created by launchpad.net/juju-core/testing.startMgoServer
	/home/tarmac/trees/src/launchpad.net/juju-core/testing/mgo.go:106 +0x500

goroutine 136 [select]:
launchpad.net/gocheck.(*resultTracker)._loopRoutine(0xc20026c280)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/gocheck.go:436 +0x2ab
created by launchpad.net/gocheck.(*resultTracker).start
	/home/tarmac/trees/src/src/launchpad.net/gocheck/gocheck.go:416 +0x2c

goroutine 668 [chan receive]:
launchpad.net/tomb.(*Tomb).Wait(0xc200a87ba0, 0xc200a889c0, 0x1240840)
	/home/tarmac/trees/src/src/launchpad.net/tomb/tomb.go:110 +0x40
launchpad.net/juju-core/cmd/jujud.(*MachineAgent).Stop(0xc200a87ba0, 0xc200418aa0, 0xc20035ea00)
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/machine.go:82 +0x37
launchpad.net/gocheck.(*C).stopNow(0xc200418aa0)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/gocheck.go:88 +0x18
launchpad.net/gocheck.(*C).Assert(0xc200418aa0, 0xb81ac0, 0xc2006a3ee0, 0xc200195480, 0xc200000098, ...)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/helpers.go:164 +0xa9
launchpad.net/juju-core/cmd/jujud.func·030(0xc200393780, 0xc20066cb40, 0xc200392ea0)
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/machine_test.go:380 +0xd1
launchpad.net/juju-core/cmd/jujud.(*MachineSuite).assertJobWithState(0xc2001dc280, 0xc200418aa0, 0x3, 0x7eff58e5ba98)
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/machine_test.go:349 +0x2bf
launchpad.net/juju-core/cmd/jujud.(*MachineSuite).TestManageStateServesAPI(0xc2001dc280, 0xc200418aa0)
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/machine_test.go:385 +0x68
reflect.Value.call(0xc21fa0, 0xc2001dc280, 0x2138, 0xc33d00, 0x4, ...)
	/usr/lib/go/src/pkg/reflect/value.go:474 +0xe9f
reflect.Value.Call(0xc21fa0, 0xc2001dc280, 0x2138, 0x7eff58e5bec8, 0x1, ...)
	/usr/lib/go/src/pkg/reflect/value.go:345 +0x9b
launchpad.net/gocheck.func·006(0xc200418aa0)
	/home/tarmac/trees/src/src/launchpad.net/gocheck/gocheck.go:733 +0x32e
launchpad.net/gocheck.func·004()
	/home/tarmac/trees/src/src/launchpad.net/gocheck/gocheck.go:628 +0x8c
created by launchpad.net/gocheck.(*suiteRunner).forkCall
	/home/tarmac/trees/src/src/launchpad.net/gocheck/gocheck.go:629 +0x1ea

goroutine 366 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200349540, 0xc200349501)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 548 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2004f58c0, 0xc2004f5801)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 664 [sleep]:
time.Sleep(0x1dcd6500)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoCluster).syncServersLoop(0xc200461380)
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:326 +0x1ec
created by labix.org/v2/mgo.newCluster
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:69 +0xf8

goroutine 552 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2004ef2a0, 0xc2004ef201)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 489 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200498a80, 0xc200498a01)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 674 [IO wait]:
net.runtime_pollWait(0x7eff58ef28c0, 0x72, 0x0)
	/usr/lib/go/src/pkg/runtime/znetpoll_linux_amd64.c:118 +0x82
net.(*pollDesc).WaitRead(0xc200724230, 0xb, 0xc2001b2300)
	/usr/lib/go/src/pkg/net/fd_poll_runtime.go:75 +0x31
net.(*netFD).accept(0xc2007241b0, 0xd999c0, 0x0, 0xc2001b2300, 0xb, ...)
	/usr/lib/go/src/pkg/net/fd_unix.go:385 +0x2c1
net.(*TCPListener).AcceptTCP(0xc2005b5748, 0x5c4526, 0x7eff58e47ec8, 0x5c4526)
	/usr/lib/go/src/pkg/net/tcpsock_posix.go:229 +0x45
net.(*TCPListener).Accept(0xc2005b5748, 0xc2003105a0, 0xc2005a2e38, 0xc20066c090, 0x0, ...)
	/usr/lib/go/src/pkg/net/tcpsock_posix.go:239 +0x25
net/http.(*Server).Serve(0xc200589280, 0xc20025d240, 0xc2005b5748, 0x0, 0x0, ...)
	/usr/lib/go/src/pkg/net/http/server.go:1542 +0x85
net/http.Serve(0xc20025d240, 0xc2005b5748, 0xc2004c2f90, 0xc200aa9240, 0xc2003c4120, ...)
	/usr/lib/go/src/pkg/net/http/server.go:1481 +0x68
created by launchpad.net/juju-core/provider/dummy.(*environState).listen
	/home/tarmac/trees/src/launchpad.net/juju-core/provider/dummy/environs.go:263 +0x42f

goroutine 741 [select]:
launchpad.net/juju-core/worker.(*Runner).run(0xc20050fba0, 0xd996a8, 0xb27660)
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:153 +0x98c
launchpad.net/juju-core/worker.func·003()
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:77 +0x4e
created by launchpad.net/juju-core/worker.NewRunner
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:78 +0x12a

goroutine 373 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc20068c7e0)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 475 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc2004d9ee0)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 678 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200aa8620, 0xc200aa8601)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 92 [finalizer wait]:

goroutine 464 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2004047e0, 0xc200404701)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 515 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc2006a3720)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 707 [sleep]:
time.Sleep(0x1dcd6500)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoCluster).syncServersLoop(0xc20060c8c0)
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:326 +0x1ec
created by labix.org/v2/mgo.newCluster
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:69 +0xf8

goroutine 683 [chan receive]:
launchpad.net/juju-core/state/apiserver.func·001()
	/home/tarmac/trees/src/launchpad.net/juju-core/state/apiserver/apiserver.go:82 +0x4c
created by launchpad.net/juju-core/state/apiserver.(*Server).run
	/home/tarmac/trees/src/launchpad.net/juju-core/state/apiserver/apiserver.go:85 +0xfd

goroutine 682 [sleep]:
time.Sleep(0x1dcd6500)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoCluster).syncServersLoop(0xc200331700)
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:326 +0x1ec
created by labix.org/v2/mgo.newCluster
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:69 +0xf8

goroutine 679 [select]:
launchpad.net/juju-core/state/watcher.(*Watcher).loop(0xc2007242d0, 0x0, 0xc20058c7b0)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/watcher/watcher.go:224 +0x20e
launchpad.net/juju-core/state/watcher.func·001()
	/home/tarmac/trees/src/launchpad.net/juju-core/state/watcher/watcher.go:116 +0x2c
created by launchpad.net/juju-core/state/watcher.New
	/home/tarmac/trees/src/launchpad.net/juju-core/state/watcher/watcher.go:118 +0x100

goroutine 328 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc20060c0e0, 0xc20060c001)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 556 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2004efa80, 0xc2004efa01)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 451 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2004a69a0, 0xc2004a6901)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 677 [IO wait]:
net.runtime_pollWait(0x7eff58ef2c80, 0x72, 0x0)
	/usr/lib/go/src/pkg/runtime/znetpoll_linux_amd64.c:118 +0x82
net.(*pollDesc).WaitRead(0xc2007242c0, 0xb, 0xc2001b2300)
	/usr/lib/go/src/pkg/net/fd_poll_runtime.go:75 +0x31
net.(*netFD).Read(0xc200724240, 0xc200226000, 0x800, 0x800, 0x0, ...)
	/usr/lib/go/src/pkg/net/fd_unix.go:195 +0x2b3
net.(*conn).Read(0xc20058c8b0, 0xc200226000, 0x800, 0x800, 0x477e4d, ...)
	/usr/lib/go/src/pkg/net/net.go:123 +0xc3
crypto/tls.(*block).readFromUntil(0xc20035c780, 0xc200318720, 0xc20058c8b0, 0x5, 0xc20058c8b0, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:401 +0xbd
crypto/tls.(*Conn).readRecord(0xc2006a8000, 0x17, 0x0, 0x408e33)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:481 +0xfa
crypto/tls.(*Conn).Read(0xc2006a8000, 0xc20035cbd0, 0x24, 0x24, 0x0, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:796 +0x102
labix.org/v2/mgo.fill(0xc200310600, 0xc2006a8000, 0xc20035cbd0, 0x24, 0x24, ...)
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:437 +0x59
labix.org/v2/mgo.(*mongoSocket).readLoop(0xc200aa88c0)
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:454 +0x113
created by labix.org/v2/mgo.newSocket
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:156 +0x266

goroutine 687 [sleep]:
time.Sleep(0x1dcd6500)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoCluster).syncServersLoop(0xc2003492a0)
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:326 +0x1ec
created by labix.org/v2/mgo.newCluster
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:69 +0xf8

goroutine 691 [select]:
launchpad.net/juju-core/state/watcher.(*Watcher).loop(0xc200724630, 0xc06680, 0xc2006ca608)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/watcher/watcher.go:224 +0x20e
launchpad.net/juju-core/state/watcher.func·001()
	/home/tarmac/trees/src/launchpad.net/juju-core/state/watcher/watcher.go:116 +0x2c
created by launchpad.net/juju-core/state/watcher.New
	/home/tarmac/trees/src/launchpad.net/juju-core/state/watcher/watcher.go:118 +0x100

goroutine 690 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200349620, 0xc200349601)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 600 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2003f37e0, 0xc2003f3701)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 670 [sleep]:
time.Sleep(0x1dcd6500)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoCluster).syncServersLoop(0xc200461b60)
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:326 +0x1ec
created by labix.org/v2/mgo.newCluster
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:69 +0xf8

goroutine 333 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc20060cc40, 0xc20060cc01)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 659 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2003f71c0, 0xc2003f7101)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 663 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2003f7c40, 0xc2003f7c01)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 441 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2006869a0, 0xc200686901)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 680 [select]:
launchpad.net/juju-core/state/presence.(*Watcher).loop(0xc200341640, 0xc200195000, 0x417ec5)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/presence/presence.go:223 +0x27e
launchpad.net/juju-core/state/presence.func·001()
	/home/tarmac/trees/src/launchpad.net/juju-core/state/presence/presence.go:114 +0x2c
created by launchpad.net/juju-core/state/presence.NewWatcher
	/home/tarmac/trees/src/launchpad.net/juju-core/state/presence/presence.go:116 +0x166

goroutine 673 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200461d20, 0xc200461d01)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 656 [sleep]:
time.Sleep(0x1dcd6500)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoCluster).syncServersLoop(0xc2003f7000)
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:326 +0x1ec
created by labix.org/v2/mgo.newCluster
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:69 +0xf8

goroutine 437 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200686000, 0xc200686001)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 210 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc2005023e0)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 567 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200331e00, 0xc200331e01)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 345 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2002881c0, 0xc200288101)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 562 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2003312a0, 0xc200331201)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 697 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc20035bc60)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 709 [chan receive]:
launchpad.net/tomb.(*Tomb).Wait(0xc20050fba0, 0xc20064a600, 0x7eff58e52ef8)
	/home/tarmac/trees/src/src/launchpad.net/tomb/tomb.go:110 +0x40
launchpad.net/juju-core/worker.(*Runner).Wait(0xc20050fba0, 0xc20064a600, 0xc2005f0300)
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:115 +0x25
launchpad.net/juju-core/cmd/jujud.(*closeWorker).Wait(0xc2003ae440, 0xc200a87d80, 0xc3e980)
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/agent.go:203 +0x30
launchpad.net/juju-core/worker.(*Runner).runWorker(0xc200a87c00, 0x2faf080, 0xc3e980, 0x3, 0xc20045d8e0, ...)
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:257 +0x3c8
created by launchpad.net/juju-core/worker.(*Runner).run
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:220 +0x927

goroutine 231 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc2004a3260)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 689 [IO wait]:
net.runtime_pollWait(0x7eff58ef2a00, 0x72, 0x0)
	/usr/lib/go/src/pkg/runtime/znetpoll_linux_amd64.c:118 +0x82
net.(*pollDesc).WaitRead(0xc200724620, 0xb, 0xc2001b2300)
	/usr/lib/go/src/pkg/net/fd_poll_runtime.go:75 +0x31
net.(*netFD).Read(0xc2007245a0, 0xc200212000, 0x800, 0x800, 0x0, ...)
	/usr/lib/go/src/pkg/net/fd_unix.go:195 +0x2b3
net.(*conn).Read(0xc2006ca708, 0xc200212000, 0x800, 0x800, 0x477e4d, ...)
	/usr/lib/go/src/pkg/net/net.go:123 +0xc3
crypto/tls.(*block).readFromUntil(0xc20059e8d0, 0xc200318720, 0xc2006ca708, 0x5, 0xc2006ca708, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:401 +0xbd
crypto/tls.(*Conn).readRecord(0xc2005ec780, 0x17, 0x0, 0x408e33)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:481 +0xfa
crypto/tls.(*Conn).Read(0xc2005ec780, 0xc20059ed50, 0x24, 0x24, 0x0, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:796 +0x102
labix.org/v2/mgo.fill(0xc200310600, 0xc2005ec780, 0xc20059ed50, 0x24, 0x24, ...)
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:437 +0x59
labix.org/v2/mgo.(*mongoSocket).readLoop(0xc2003498c0)
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:454 +0x113
created by labix.org/v2/mgo.newSocket
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:156 +0x266

goroutine 672 [IO wait]:
net.runtime_pollWait(0x7eff58ef2f00, 0x72, 0x0)
	/usr/lib/go/src/pkg/runtime/znetpoll_linux_amd64.c:118 +0x82
net.(*pollDesc).WaitRead(0xc2006f9620, 0xb, 0xc2001b2300)
	/usr/lib/go/src/pkg/net/fd_poll_runtime.go:75 +0x31
net.(*netFD).Read(0xc2006f95a0, 0xc20044cc00, 0x400, 0x400, 0x0, ...)
	/usr/lib/go/src/pkg/net/fd_unix.go:195 +0x2b3
net.(*conn).Read(0xc2003b3af8, 0xc20044cc00, 0x400, 0x400, 0x477e4d, ...)
	/usr/lib/go/src/pkg/net/net.go:123 +0xc3
crypto/tls.(*block).readFromUntil(0xc200611a50, 0xc200318720, 0xc2003b3af8, 0x5, 0xc2003b3af8, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:401 +0xbd
crypto/tls.(*Conn).readRecord(0xc20053e280, 0x17, 0x0, 0x408e33)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:481 +0xfa
crypto/tls.(*Conn).Read(0xc20053e280, 0xc200612870, 0x24, 0x24, 0x0, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:796 +0x102
labix.org/v2/mgo.fill(0xc200310600, 0xc20053e280, 0xc200612870, 0x24, 0x24, ...)
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:437 +0x59
labix.org/v2/mgo.(*mongoSocket).readLoop(0xc2001a6620)
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:454 +0x113
created by labix.org/v2/mgo.newSocket
	/home/tarmac/trees/src/labix.org/v2/mgo/socket.go:156 +0x266

goroutine 681 [IO wait]:
net.runtime_pollWait(0x7eff58ef2be0, 0x72, 0x0)
	/usr/lib/go/src/pkg/runtime/znetpoll_linux_amd64.c:118 +0x82
net.(*pollDesc).WaitRead(0xc200724500, 0xb, 0xc2001b2300)
	/usr/lib/go/src/pkg/net/fd_poll_runtime.go:75 +0x31
net.(*netFD).accept(0xc200724480, 0xd999c0, 0x0, 0xc2001b2300, 0xb, ...)
	/usr/lib/go/src/pkg/net/fd_unix.go:385 +0x2c1
net.(*TCPListener).AcceptTCP(0xc200250720, 0xc200264400, 0x8, 0x80065a170)
	/usr/lib/go/src/pkg/net/tcpsock_posix.go:229 +0x45
net.(*TCPListener).Accept(0xc200250720, 0xd999e8, 0x7eff58e31e90, 0x8, 0x5c4526, ...)
	/usr/lib/go/src/pkg/net/tcpsock_posix.go:239 +0x25
crypto/tls.(*listener).Accept(0xc2004a5420, 0x0, 0x0, 0x0, 0x0, ...)
	/usr/lib/go/src/pkg/crypto/tls/tls.go:46 +0x51
net/http.(*Server).Serve(0xc200492c80, 0xc2003fb0c0, 0xc2004a5420, 0x0, 0x0, ...)
	/usr/lib/go/src/pkg/net/http/server.go:1542 +0x85
net/http.Serve(0xc2003fb0c0, 0xc2004a5420, 0xc20028d270, 0xc2004dc2c0, 0xc20025a740, ...)
	/usr/lib/go/src/pkg/net/http/server.go:1481 +0x68
launchpad.net/juju-core/state/apiserver.(*Server).run(0xc200514060, 0xc2003fb0c0, 0xc2004a5420)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/apiserver/apiserver.go:101 +0x15b
created by launchpad.net/juju-core/state/apiserver.NewServer
	/home/tarmac/trees/src/launchpad.net/juju-core/state/apiserver/apiserver.go:51 +0x3cc

goroutine 579 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200686700, 0xc200686701)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 675 [sleep]:
time.Sleep(0x1dcd6500)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoCluster).syncServersLoop(0xc200aa8460)
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:326 +0x1ec
created by labix.org/v2/mgo.newCluster
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:69 +0xf8

goroutine 667 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200461540, 0xc200461501)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 575 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc200349c40, 0xc200349c01)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 711 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc20060cd20, 0xc20060cd01)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 456 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc20031e620, 0xc20031e601)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 352 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc20049c6e0)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 468 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2004981c0, 0xc200498101)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 660 [sleep]:
time.Sleep(0x1dcd6500)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoCluster).syncServersLoop(0xc2003f79a0)
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:326 +0x1ec
created by labix.org/v2/mgo.newCluster
	/home/tarmac/trees/src/labix.org/v2/mgo/cluster.go:69 +0xf8

goroutine 445 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2004a61c0, 0xc2004a6101)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9

goroutine 703 [select]:
launchpad.net/juju-core/worker.(*Runner).run(0xc200a87c00, 0xc06680, 0x417ec5)
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:153 +0x98c
launchpad.net/juju-core/worker.func·003()
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:77 +0x4e
created by launchpad.net/juju-core/worker.NewRunner
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:78 +0x12a

goroutine 737 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc200a33c00)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 742 [runnable]:
launchpad.net/tomb.(*Tomb).Wait(0xc2003fc5c0, 0x522b5e, 0x522b5e)
	/home/tarmac/trees/src/src/launchpad.net/tomb/tomb.go:110 +0x40
launchpad.net/juju-core/worker.(*notifyWorker).Wait(0xc2003fc5c0, 0xc20050fd20, 0xc783d0)
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/notifyworker.go:65 +0x25
launchpad.net/juju-core/worker.(*Runner).runWorker(0xc20050fba0, 0x0, 0xc783d0, 0x8, 0xc2003ae3e0, ...)
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:257 +0x3c8
created by launchpad.net/juju-core/worker.(*Runner).run
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:170 +0x33d

goroutine 704 [chan receive]:
launchpad.net/tomb.(*Tomb).Wait(0xc200a87c00, 0x3, 0xc20045d8e0)
	/home/tarmac/trees/src/src/launchpad.net/tomb/tomb.go:110 +0x40
launchpad.net/juju-core/worker.(*Runner).Wait(0xc200a87c00, 0xc3e980, 0x3)
	/home/tarmac/trees/src/launchpad.net/juju-core/worker/runner.go:115 +0x25
launchpad.net/juju-core/cmd/jujud.(*MachineAgent).Run(0xc200a87ba0, 0x0, 0x0, 0x0)
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/machine.go:120 +0x35d
launchpad.net/juju-core/cmd/jujud.func·029()
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/machine_test.go:343 +0x39
created by launchpad.net/juju-core/cmd/jujud.(*MachineSuite).assertJobWithState
	/home/tarmac/trees/src/launchpad.net/juju-core/cmd/jujud/machine_test.go:344 +0x1f2

goroutine 695 [IO wait]:
net.runtime_pollWait(0x7eff58ef2b40, 0x72, 0x0)
	/usr/lib/go/src/pkg/runtime/znetpoll_linux_amd64.c:118 +0x82
net.(*pollDesc).WaitRead(0xc2007247d0, 0xb, 0xc2001b2300)
	/usr/lib/go/src/pkg/net/fd_poll_runtime.go:75 +0x31
net.(*netFD).Read(0xc200724750, 0xc2006d7000, 0x400, 0x400, 0x0, ...)
	/usr/lib/go/src/pkg/net/fd_unix.go:195 +0x2b3
net.(*conn).Read(0xc200251708, 0xc2006d7000, 0x400, 0x400, 0x0, ...)
	/usr/lib/go/src/pkg/net/net.go:123 +0xc3
crypto/tls.(*block).readFromUntil(0xc2006d2ba0, 0xc200318720, 0xc200251708, 0x5, 0xc200251708, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:401 +0xbd
crypto/tls.(*Conn).readRecord(0xc200409280, 0x17, 0x0, 0x0)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:481 +0xfa
crypto/tls.(*Conn).Read(0xc200409280, 0xc2006ba000, 0x1000, 0x1000, 0x0, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:796 +0x102
bufio.(*Reader).fill(0xc200305720)
	/usr/lib/go/src/pkg/bufio/bufio.go:79 +0x10c
bufio.(*Reader).ReadByte(0xc200305720, 0xc2002fbe10, 0x0, 0x0)
	/usr/lib/go/src/pkg/bufio/bufio.go:171 +0x7d
code.google.com/p/go.net/websocket.hybiFrameReaderFactory.NewFrameReader(0xc200305720, 0xc2005f1320, 0xc2002fbe10, 0x0, 0x0, ...)
	/home/tarmac/trees/src/src/code.google.com/p/go.net/websocket/hybi.go:126 +0xc7
code.google.com/p/go.net/websocket.Codec.Receive(0xd98df0, 0xd98df8, 0xc20066c990, 0x9bc160, 0xc20051a370, ...)
	/home/tarmac/trees/src/src/code.google.com/p/go.net/websocket/websocket.go:318 +0x145
launchpad.net/juju-core/rpc/jsoncodec.wsJSONConn.Receive(0xc20066c990, 0x9bc160, 0xc20051a370, 0x4161ec, 0x1237930, ...)
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/jsoncodec/conn.go:24 +0x53
launchpad.net/juju-core/rpc/jsoncodec.(*Codec).ReadHeader(0xc20051a370, 0xc2003059c0, 0x0, 0x0)
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/jsoncodec/codec.go:109 +0x538
launchpad.net/juju-core/rpc.(*Conn).loop(0xc20066ca20, 0xc200000000, 0x158e0ef40)
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/server.go:286 +0x83
launchpad.net/juju-core/rpc.(*Conn).input(0xc20066ca20)
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/server.go:259 +0x30
created by launchpad.net/juju-core/rpc.(*Conn).Start
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/server.go:140 +0x96

goroutine 692 [select]:
launchpad.net/juju-core/state/presence.(*Watcher).loop(0xc200697f00, 0x0, 0x0)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/presence/presence.go:223 +0x27e
launchpad.net/juju-core/state/presence.func·001()
	/home/tarmac/trees/src/launchpad.net/juju-core/state/presence/presence.go:114 +0x2c
created by launchpad.net/juju-core/state/presence.NewWatcher
	/home/tarmac/trees/src/launchpad.net/juju-core/state/presence/presence.go:116 +0x166

goroutine 586 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc200391fc0)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 693 [select]:
launchpad.net/juju-core/state/apiserver.(*Server).serveConn(0xc200514060, 0xc20066c870, 0xc200195000, 0xc200173540)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/apiserver/apiserver.go:119 +0x27c
launchpad.net/juju-core/state/apiserver.func·002(0xc20066c870)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/apiserver/apiserver.go:96 +0xd8
code.google.com/p/go.net/websocket.Server.serveWebSocket(0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/home/tarmac/trees/src/src/code.google.com/p/go.net/websocket/server.go:98 +0x230
code.google.com/p/go.net/websocket.Handler.ServeHTTP(0xc2004dc2c0, 0xc2005f65c0, 0xc2004d8d20, 0xc2004e0820)
	/home/tarmac/trees/src/src/code.google.com/p/go.net/websocket/server.go:121 +0x9b
net/http.serverHandler.ServeHTTP(0xc200492c80, 0xc2005f65c0, 0xc2004d8d20, 0xc2004e0820)
	/usr/lib/go/src/pkg/net/http/server.go:1517 +0x16c
net/http.(*conn).serve(0xc200724870)
	/usr/lib/go/src/pkg/net/http/server.go:1096 +0x765
created by net/http.(*Server).Serve
	/usr/lib/go/src/pkg/net/http/server.go:1564 +0x266

goroutine 626 [sleep]:
time.Sleep(0xdf8475800)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
launchpad.net/juju-core/state/api.(*State).heartbeatMonitor(0xc2006a3020)
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:144 +0x85
created by launchpad.net/juju-core/state/api.Open
	/home/tarmac/trees/src/launchpad.net/juju-core/state/api/apiclient.go:131 +0x515

goroutine 694 [IO wait]:
net.runtime_pollWait(0x7eff58ef2960, 0x72, 0x0)
	/usr/lib/go/src/pkg/runtime/znetpoll_linux_amd64.c:118 +0x82
net.(*pollDesc).WaitRead(0xc200724860, 0xb, 0xc2001b2300)
	/usr/lib/go/src/pkg/net/fd_poll_runtime.go:75 +0x31
net.(*netFD).Read(0xc2007247e0, 0xc2006d6000, 0x400, 0x400, 0x0, ...)
	/usr/lib/go/src/pkg/net/fd_unix.go:195 +0x2b3
net.(*conn).Read(0xc2002516c0, 0xc2006d6000, 0x400, 0x400, 0xc20027b120, ...)
	/usr/lib/go/src/pkg/net/net.go:123 +0xc3
crypto/tls.(*block).readFromUntil(0xc2006d29f0, 0xc200318720, 0xc2002516c0, 0x5, 0xc2002516c0, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:401 +0xbd
crypto/tls.(*Conn).readRecord(0xc20053ec80, 0x17, 0x0, 0xc20027b220)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:481 +0xfa
crypto/tls.(*Conn).Read(0xc20053ec80, 0xc2006d4000, 0x1000, 0x1000, 0x0, ...)
	/usr/lib/go/src/pkg/crypto/tls/conn.go:796 +0x102
net/http.(*liveSwitchReader).Read(0xc200724898, 0xc2006d4000, 0x1000, 0x1000, 0x7effffffffff, ...)
	/usr/lib/go/src/pkg/net/http/server.go:205 +0x91
io.(*LimitedReader).Read(0xc200294480, 0xc2006d4000, 0x1000, 0x1000, 0x50, ...)
	/usr/lib/go/src/pkg/io/io.go:394 +0xc0
net/http.(*switchReader).Read(0xc20065a160, 0xc2006d4000, 0x1000, 0x1000, 0x0, ...)
	/usr/lib/go/src/pkg/net/http/chunked.go:0 +0x62
bufio.(*Reader).fill(0xc200648c60)
	/usr/lib/go/src/pkg/bufio/bufio.go:79 +0x10c
bufio.(*Reader).ReadByte(0xc200648c60, 0xc2002fbc30, 0x0, 0x0)
	/usr/lib/go/src/pkg/bufio/bufio.go:171 +0x7d
code.google.com/p/go.net/websocket.hybiFrameReaderFactory.NewFrameReader(0xc200648c60, 0xc2005f1320, 0xc2002fbc30, 0x0, 0x0, ...)
	/home/tarmac/trees/src/src/code.google.com/p/go.net/websocket/hybi.go:126 +0xc7
code.google.com/p/go.net/websocket.Codec.Receive(0xd98df0, 0xd98df8, 0xc20066c870, 0xb3e580, 0xc2004fc540, ...)
	/home/tarmac/trees/src/src/code.google.com/p/go.net/websocket/websocket.go:318 +0x145
launchpad.net/juju-core/rpc/jsoncodec.wsJSONConn.Receive(0xc20066c870, 0xb3e580, 0xc2004fc540, 0x419f41, 0xc200178000, ...)
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/jsoncodec/conn.go:24 +0x53
launchpad.net/juju-core/rpc/jsoncodec.(*Codec).ReadHeader(0xc20051a2c0, 0xc200305840, 0x0, 0x0)
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/jsoncodec/codec.go:101 +0xc8
launchpad.net/juju-core/rpc.(*Conn).loop(0xc20066c900, 0xc200000000, 0x158e4df40)
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/server.go:286 +0x83
launchpad.net/juju-core/rpc.(*Conn).input(0xc20066c900)
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/server.go:259 +0x30
created by launchpad.net/juju-core/rpc.(*Conn).Start
	/home/tarmac/trees/src/launchpad.net/juju-core/rpc/server.go:140 +0x96

goroutine 686 [sleep]:
time.Sleep(0x2540be400)
	/usr/lib/go/src/pkg/runtime/ztime_linux_amd64.c:19 +0x2f
labix.org/v2/mgo.(*mongoServer).pinger(0xc2003318c0, 0xc200331801)
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:270 +0xfd
created by labix.org/v2/mgo.newServer
	/home/tarmac/trees/src/labix.org/v2/mgo/server.go:80 +0xd9
FAIL	launchpad.net/juju-core/cmd/jujud	26.130s
ok  	launchpad.net/juju-core/cmd/plugins/juju-metadata	1.361s
ok  	launchpad.net/juju-core/constraints	0.023s
ok  	launchpad.net/juju-core/container/lxc	0.334s
?   	launchpad.net/juju-core/container/lxc/mock	[no test files]
ok  	launchpad.net/juju-core/downloader	5.258s
ok  	launchpad.net/juju-core/environs	1.224s
ok  	launchpad.net/juju-core/environs/bootstrap	0.018s
ok  	launchpad.net/juju-core/environs/cloudinit	0.425s
ok  	launchpad.net/juju-core/environs/config	0.715s
ok  	launchpad.net/juju-core/environs/imagemetadata	0.316s
ok  	launchpad.net/juju-core/environs/instances	0.216s
ok  	launchpad.net/juju-core/environs/jujutest	0.324s
ok  	launchpad.net/juju-core/environs/localstorage	0.241s
ok  	launchpad.net/juju-core/environs/simplestreams	0.248s
?   	launchpad.net/juju-core/environs/simplestreams/testing	[no test files]
ok  	launchpad.net/juju-core/environs/sync	0.290s
ok  	launchpad.net/juju-core/environs/testing	0.010s
ok  	launchpad.net/juju-core/environs/tools	29.846s
?   	launchpad.net/juju-core/errors	[no test files]
ok  	launchpad.net/juju-core/instance	0.018s
ok  	launchpad.net/juju-core/juju	13.629s
ok  	launchpad.net/juju-core/juju/osenv	0.271s
?   	launchpad.net/juju-core/juju/testing	[no test files]
ok  	launchpad.net/juju-core/log	0.015s
ok  	launchpad.net/juju-core/log/syslog	0.030s
ok  	launchpad.net/juju-core/names	0.019s
?   	launchpad.net/juju-core/provider	[no test files]
?   	launchpad.net/juju-core/provider/all	[no test files]
ok  	launchpad.net/juju-core/provider/azure	4.330s
ok  	launchpad.net/juju-core/provider/dummy	17.147s
ok  	launchpad.net/juju-core/provider/ec2	4.360s
ok  	launchpad.net/juju-core/provider/local	1.259s
?   	launchpad.net/juju-core/provider/local/storage	[no test files]
ok  	launchpad.net/juju-core/provider/maas	2.110s
ok  	launchpad.net/juju-core/provider/openstack	4.039s
ok  	launchpad.net/juju-core/rpc	0.283s
ok  	launchpad.net/juju-core/rpc/jsoncodec	0.275s
ok  	launchpad.net/juju-core/schema	0.018s
ok  	launchpad.net/juju-core/state	61.383s
?   	launchpad.net/juju-core/state/api	[no test files]
ok  	launchpad.net/juju-core/state/api/agent	1.803s
?   	launchpad.net/juju-core/state/api/common	[no test files]
ok  	launchpad.net/juju-core/state/api/deployer	5.003s
ok  	launchpad.net/juju-core/state/api/machiner	2.645s
ok  	launchpad.net/juju-core/state/api/params	0.030s
ok  	launchpad.net/juju-core/state/api/uniter	2.807s
ok  	launchpad.net/juju-core/state/api/upgrader	2.956s
ok  	launchpad.net/juju-core/state/api/watcher	2.893s
ok  	launchpad.net/juju-core/state/apiserver	2.533s
ok  	launchpad.net/juju-core/state/apiserver/agent	2.438s
ok  	launchpad.net/juju-core/state/apiserver/client	16.504s
ok  	launchpad.net/juju-core/state/apiserver/common	0.336s
ok  	launchpad.net/juju-core/state/apiserver/deployer	3.801s
ok  	launchpad.net/juju-core/state/apiserver/machine	3.595s
?   	launchpad.net/juju-core/state/apiserver/testing	[no test files]
ok  	launchpad.net/juju-core/state/apiserver/uniter	13.019s
ok  	launchpad.net/juju-core/state/apiserver/upgrader	3.760s
ok  	launchpad.net/juju-core/state/multiwatcher	0.970s
ok  	launchpad.net/juju-core/state/presence	6.476s
ok  	launchpad.net/juju-core/state/statecmd	6.023s
?   	launchpad.net/juju-core/state/testing	[no test files]
ok  	launchpad.net/juju-core/state/watcher	5.375s
ok  	launchpad.net/juju-core/store	18.051s
ok  	launchpad.net/juju-core/testing	1.392s
ok  	launchpad.net/juju-core/testing/checkers	0.017s
ok  	launchpad.net/juju-core/thirdparty/pbkdf2	0.133s
ok  	launchpad.net/juju-core/tools	0.018s
ok  	launchpad.net/juju-core/upstart	0.116s
ok  	launchpad.net/juju-core/utils	0.966s
ok  	launchpad.net/juju-core/utils/fslock	1.038s
ok  	launchpad.net/juju-core/utils/parallel	0.424s
ok  	launchpad.net/juju-core/utils/set	0.018s
ok  	launchpad.net/juju-core/version	0.061s
ok  	launchpad.net/juju-core/worker	1.638s
ok  	launchpad.net/juju-core/worker/cleaner	1.187s
ok  	launchpad.net/juju-core/worker/deployer	3.365s
ok  	launchpad.net/juju-core/worker/firewaller	10.703s
ok  	launchpad.net/juju-core/worker/machiner	2.427s
ok  	launchpad.net/juju-core/worker/minunitsworker	1.224s
ok  	launchpad.net/juju-core/worker/provisioner	6.486s
ok  	launchpad.net/juju-core/worker/resumer	1.442s
ok  	launchpad.net/juju-core/worker/uniter	127.942s
ok  	launchpad.net/juju-core/worker/uniter/charm	3.201s
ok  	launchpad.net/juju-core/worker/uniter/debug	1.136s
ok  	launchpad.net/juju-core/worker/uniter/hook	0.014s
ok  	launchpad.net/juju-core/worker/uniter/jujuc	0.462s
ok  	launchpad.net/juju-core/worker/uniter/relation	1.304s
ok  	launchpad.net/juju-core/worker/upgrader	2.378s

warning: building out-of-date packages:
	launchpad.net/gwacl
	launchpad.net/goamz/ec2/ec2test
	launchpad.net/goamz/s3/s3test
	launchpad.net/goose/testservices/hook
	launchpad.net/goose/testservices/identityservice
	launchpad.net/goose/testservices
	launchpad.net/goose/testservices/novaservice
	launchpad.net/goose/testservices/swiftservice
	launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.

Revision history for this message

William Reade (fwereade) wrote on 2013-08-28:

LGTM also fwiw

https://codereview.appspot.com/13336043/

Revision history for this message

Go Bot (go-bot) wrote on 2013-08-28:

Download full text (16.4 KiB)

The attempt to merge lp:~rogpeppe/juju-core/377-fix-server-error into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/agent 0.757s
ok launchpad.net/juju-core/agent/tools 0.252s
ok launchpad.net/juju-core/bzr 6.454s
ok launchpad.net/juju-core/cert 2.251s
ok launchpad.net/juju-core/charm 0.561s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.020s
ok launchpad.net/juju-core/cmd 0.263s
? launchpad.net/juju-core/cmd/builddb [no test files]
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 111.567s

----------------------------------------------------------------------
FAIL: machine_test.go:377: MachineSuite.TestManageStateServesAPI

The attempt to merge lp:~rogpeppe/juju-core/377-fix-server-error into lp:juju-core failed. Below is the output from the failed tests.

ok  	launchpad.net/juju-core/agent	0.757s
ok  	launchpad.net/juju-core/agent/tools	0.252s
ok  	launchpad.net/juju-core/bzr	6.454s
ok  	launchpad.net/juju-core/cert	2.251s
ok  	launchpad.net/juju-core/charm	0.561s
?   	launchpad.net/juju-core/charm/hooks	[no test files]
ok  	launchpad.net/juju-core/cloudinit	0.020s
ok  	launchpad.net/juju-core/cmd	0.263s
?   	launchpad.net/juju-core/cmd/builddb	[no test files]
?   	launchpad.net/juju-core/cmd/charmd	[no test files]
?   	launchpad.net/juju-core/cmd/charmload	[no test files]
ok  	launchpad.net/juju-core/cmd/juju	111.567s

----------------------------------------------------------------------
FAIL: machine_test.go:377: MachineSuite.TestManageStateServesAPI

[LOG] 81.15455 INFO juju environs/testing: uploading FAKE tools 1.13.3-precise-amd64
[LOG] 81.17106 INFO juju.environs.boostrap bootstrapping environment "dummyenv"
[LOG] 81.17109 INFO juju.environs.tools reading tools with major version 1
[LOG] 81.17111 INFO juju.environs.tools filtering tools by version: 1.13.3
[LOG] 81.17112 INFO juju.environs.tools filtering tools by series: precise
[LOG] 81.17113 DEBUG juju.environs.tools reading v1.* tools
[LOG] 81.17114 INFO juju.environs.tools falling back to public bucket
[LOG] 81.17115 DEBUG juju.environs.tools reading v1.* tools
[LOG] 81.17119 DEBUG juju.environs.tools found 1.13.3-precise-amd64
[LOG] 81.17123 INFO juju environs/dummy: would pick tools from 1.13.3-precise-amd64
[LOG] 81.19443 INFO juju.state opening state; mongo addresses: ["localhost:53646"]; entity ""
[LOG] 81.19747 INFO juju.state connection established
[LOG] 81.21240 INFO juju.state initializing environment
[LOG] 81.24281 INFO juju state/api: listening on "127.0.0.1:45956"
[LOG] 81.26227 INFO juju.state opening state; mongo addresses: ["localhost:53646"]; entity ""
[LOG] 81.28891 INFO juju.state connection established
[LOG] 81.29111 INFO juju juju: authorization error while connecting to state server; retrying
[LOG] 81.29136 INFO juju.state opening state; mongo addresses: ["localhost:53646"]; entity ""
[LOG] 81.29599 INFO juju.state connection established
[LOG] 81.32019 INFO juju state/api: dialing "wss://127.0.0.1:45956/"
[LOG] 81.32306 INFO juju state/api: connection established
[LOG] 81.32317 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret","Nonce":""}}
[LOG] 81.32349 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 81.32375 INFO juju.container.lxc lxcObjectFactory replaced with mock lxc factory
[LOG] 81.32485 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"Pinger","Request":"Ping","Params":{}}
[LOG] 81.32492 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Response":{}}
[LOG] 81.39595 INFO juju machine agent machine-0 start
[LOG] 81.41037 INFO juju Starting StateWorker for machine-0
[LOG] 81.41041 INFO juju worker: start "state"
[LOG] 81.41044 INFO juju.state opening state; mongo addresses: ["localhost:53646"]; entity "machine-0"
[LOG] 81.41067 INFO juju worker: start "api"
[LOG] 81.41088 INFO juju state/api: dialing "wss://localhost:53718/"
[LOG] 81.41118 ERROR juju state/api: websocket.Dial wss://localhost:53718/: dial tcp 127.0.0.1:53718: connection refused
[LOG] 81.41124 ERROR juju worker: exited "api": websocket.Dial wss://localhost:53718/: dial tcp 127.0.0.1:53718: connection refused
[LOG] 81.41166 INFO juju worker: restarting "api" in 50ms
[LOG] 81.41349 INFO juju.state connection established
[LOG] 81.44276 INFO juju state/api: dialing "wss://localhost:53718/"
[LOG] 81.44320 INFO juju worker: start "lxc-provisioner"
[LOG] 81.44329 INFO juju worker: start "apiserver"
[LOG] 81.44342 INFO juju state/api: listening on "[::]:53718"
[LOG] 81.46736 INFO juju worker: start "cleaner"
[LOG] 81.46764 INFO juju worker: start "resumer"
[LOG] 81.46781 INFO juju worker: start "minunitsworker"
[LOG] 81.46799 ERROR juju state/api: websocket.Dial wss://localhost:53718/: dial tcp 127.0.0.1:53718: connection refused
[LOG] 81.46802 INFO juju worker: start "api"
[LOG] 81.46822 INFO juju state/api: dialing "wss://localhost:53718/"
[LOG] 81.47193 INFO juju state/api: connection established
[LOG] 81.47203 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"machine-0","Password":"machine-password","Nonce":"user-admin:bootstrap"}}
[LOG] 81.47379 INFO juju.provisioner Starting up provisioner task 0
[LOG] 81.47523 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 81.48880 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"Pinger","Request":"Ping","Params":{}}
[LOG] 81.48889 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Response":{}}
[LOG] 81.48917 DEBUG juju rpc/jsoncodec: <- {"RequestId":3,"Type":"Agent","Request":"GetEntities","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 81.48964 DEBUG juju rpc/jsoncodec: -> {"RequestId":3,"Response":{"Entities":[{"Life":"alive","Jobs":["JobManageState"],"Error":null}]}}
[LOG] 81.48982 DEBUG juju rpc/jsoncodec: <- {"RequestId":4,"Type":"Agent","Request":"SetPasswords","Params":{"Changes":[{"Tag":"machine-0","Password":"PBiMC8xB7YcbImoPT0KOYATj"}]}}
[LOG] 81.49337 DEBUG juju rpc/jsoncodec: -> {"RequestId":4,"Response":{"Results":[{"Error":null}]}}
[LOG] 81.49351 INFO juju worker: start "machiner"
[LOG] 81.49358 INFO juju worker: start "upgrader"
[LOG] 81.49374 DEBUG juju rpc/jsoncodec: <- {"RequestId":5,"Type":"Machiner","Request":"Life","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 81.49380 DEBUG juju rpc/jsoncodec: <- {"RequestId":6,"Type":"Upgrader","Request":"SetTools","Params":{"AgentTools":[{"Tag":"machine-0","Tools":{"Version":"1.13.3-precise-amd64","URL":"http://127.0.0.1:48398/dummyenv/private/tools/juju-1.13.3-precise-amd64.tgz"}}]}}
[LOG] 81.49423 DEBUG juju rpc/jsoncodec: -> {"RequestId":5,"Response":{"Results":[{"Life":"alive","Error":null}]}}
[LOG] 81.49495 DEBUG juju rpc/jsoncodec: <- {"RequestId":7,"Type":"Machiner","Request":"SetStatus","Params":{"Entities":[{"Tag":"machine-0","Status":"started","Info":""}],"Machines":null}}
[LOG] 81.49898 DEBUG juju rpc/jsoncodec: -> {"RequestId":6,"Response":{"Results":[{"Error":null}]}}
[LOG] 81.49946 DEBUG juju rpc/jsoncodec: <- {"RequestId":8,"Type":"Upgrader","Request":"WatchAPIVersion","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 81.50012 DEBUG juju rpc/jsoncodec: -> {"RequestId":8,"Response":{"Results":[{"NotifyWatcherId":"2","Error":null}]}}
[LOG] 81.50070 DEBUG juju rpc/jsoncodec: <- {"RequestId":9,"Type":"Upgrader","Request":"Tools","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 81.50076 DEBUG juju rpc/jsoncodec: <- {"RequestId":10,"Type":"NotifyWatcher","Id":"2","Request":"Next","Params":{}}
[LOG] 81.50283 INFO juju.environs.tools finding exact version 1.13.3-precise-amd64
[LOG] 81.50285 INFO juju.environs.tools reading tools with major version 1
[LOG] 81.50286 INFO juju.environs.tools filtering tools by version: 1.13.3
[LOG] 81.50287 INFO juju.environs.tools filtering tools by series: precise
[LOG] 81.50288 INFO juju.environs.tools filtering tools by architecture: amd64
[LOG] 81.50290 DEBUG juju.environs.tools reading v1.* tools
[LOG] 81.50294 DEBUG juju.environs.tools found 1.13.3-precise-amd64
[LOG] 81.50302 DEBUG juju rpc/jsoncodec: -> {"RequestId":9,"Response":{"Results":[{"Tools":{"Version":"1.13.3-precise-amd64","URL":"http://127.0.0.1:48398/dummyenv/private/tools/juju-1.13.3-precise-amd64.tgz"},"Error":null}]}}
[LOG] 81.50336 INFO juju.worker.upgrader required tools: 1.13.3-precise-amd64
[LOG] 81.50463 DEBUG juju rpc/jsoncodec: -> {"RequestId":7,"Response":{"Results":[{"Error":null}]}}
[LOG] 81.50476 INFO juju.worker.machiner "machine-0" started
[LOG] 81.50485 DEBUG juju rpc/jsoncodec: <- {"RequestId":11,"Type":"Machiner","Request":"Watch","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 81.50550 DEBUG juju rpc/jsoncodec: -> {"RequestId":11,"Response":{"Results":[{"NotifyWatcherId":"3","Error":null}]}}
[LOG] 81.50573 DEBUG juju rpc/jsoncodec: <- {"RequestId":12,"Type":"Machiner","Request":"Life","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 81.50578 DEBUG juju rpc/jsoncodec: <- {"RequestId":13,"Type":"NotifyWatcher","Id":"3","Request":"Next","Params":{}}
[LOG] 81.50621 DEBUG juju rpc/jsoncodec: -> {"RequestId":12,"Response":{"Results":[{"Life":"alive","Error":null}]}}
[LOG] 81.50710 INFO juju state/api: dialing "wss://localhost:53718/"
[LOG] 81.51060 INFO juju state/api: connection established
[LOG] 81.51072 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"machine-0","Password":"machine-password","Nonce":"user-admin:bootstrap"}}
[LOG] 81.51126 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Error":"invalid entity name or password","ErrorCode":"unauthorized access","Response":{}}
machine_test.go:385:
    s.assertJobWithState(c, state.JobManageState, func(conf agent.Config, agentState *state.State) {
        st, _, err := conf.OpenAPI(fastDialOpts)
        c.Assert(err, gc.IsNil)
        defer st.Close()
        m, err := st.Machiner().Machine(conf.Tag())
        c.Assert(err, gc.IsNil)
        c.Assert(m.Life(), gc.Equals, params.Alive)
    })
machine_test.go:380:
    c.Assert(err, gc.IsNil)
... value *params.Error = &params.Error{"unauthorized access", "invalid entity name or password"} ("invalid entity name or password")

[LOG] 81.51944 DEBUG juju worker: killing runner 0xc2006f9180
[LOG] 81.51953 INFO juju worker: runner is dying
[LOG] 81.51955 DEBUG juju worker: killing "state"
[LOG] 81.51955 DEBUG juju worker: killing runner 0xc200823ba0
[LOG] 81.51956 DEBUG juju worker: killing "api"
[LOG] 81.51957 DEBUG juju worker: killing runner 0xc200190e40
[LOG] 81.51959 INFO juju worker: runner is dying
[LOG] 81.51960 DEBUG juju worker: killing "lxc-provisioner"
[LOG] 81.52036 DEBUG juju worker: killing "apiserver"
[LOG] 81.52038 DEBUG juju worker: killing "cleaner"
[LOG] 81.52039 DEBUG juju worker: killing "resumer"
[LOG] 81.52040 DEBUG juju worker: killing "minunitsworker"
[LOG] 81.52042 INFO juju worker: runner is dying
[LOG] 81.52043 DEBUG juju worker: killing "machiner"
[LOG] 81.52044 DEBUG juju worker: killing "upgrader"
[LOG] 81.52060 INFO juju.provisioner Shutting down provisioner task 0
[LOG] 81.52100 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:43310: use of closed network connection (closing true)
[LOG] 81.52109 DEBUG juju rpc/jsoncodec: <- {"RequestId":14,"Type":"NotifyWatcher","Id":"3","Request":"Stop","Params":{}}
[LOG] 81.52587 DEBUG juju rpc/jsoncodec: -> {"RequestId":10,"Error":"watcher has been stopped","ErrorCode":"stopped","Response":{}}
[LOG] 81.52599 DEBUG juju rpc/jsoncodec: -> {"RequestId":13,"Error":"watcher has been stopped","ErrorCode":"stopped","Response":{}}
[LOG] 81.52616 DEBUG juju rpc/jsoncodec: -> {"RequestId":14,"Error":"connection is shut down","Response":{}}
[LOG] 81.52653 ERROR juju state/api: error trying to stop watcher connection is shut down
[LOG] 81.52657 ERROR juju state/api: error trying to stop watcher connection is shut down
[LOG] 81.52676 INFO juju.container.lxc lxcObjectFactory replaced with &{}
[LOG] 81.52784 INFO juju environs/dummy: reset environment
[LOG] 81.52803 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:44215: use of closed network connection (closing true)
[jujuc whatever]
[remote]
[/path/to/remote]
[remote --help]
[unknown]
[remote --error borken]
[remote --unknown]
[remote unwanted]
OOPS: 31 passed, 3 skipped, 1 FAILED
--- FAIL: TestPackage (36.34 seconds)
FAIL
FAIL	launchpad.net/juju-core/cmd/jujud	36.633s
ok  	launchpad.net/juju-core/cmd/plugins/juju-metadata	1.315s
ok  	launchpad.net/juju-core/constraints	0.029s
ok  	launchpad.net/juju-core/container/lxc	0.396s
?   	launchpad.net/juju-core/container/lxc/mock	[no test files]
ok  	launchpad.net/juju-core/downloader	5.296s
ok  	launchpad.net/juju-core/environs	1.274s
ok  	launchpad.net/juju-core/environs/bootstrap	0.015s
ok  	launchpad.net/juju-core/environs/cloudinit	0.454s
ok  	launchpad.net/juju-core/environs/config	0.846s
ok  	launchpad.net/juju-core/environs/imagemetadata	0.300s
ok  	launchpad.net/juju-core/environs/instances	0.221s
ok  	launchpad.net/juju-core/environs/jujutest	0.225s
ok  	launchpad.net/juju-core/environs/localstorage	0.298s
ok  	launchpad.net/juju-core/environs/simplestreams	0.299s
?   	launchpad.net/juju-core/environs/simplestreams/testing	[no test files]
ok  	launchpad.net/juju-core/environs/sync	0.239s
ok  	launchpad.net/juju-core/environs/testing	0.010s
ok  	launchpad.net/juju-core/environs/tools	23.594s
?   	launchpad.net/juju-core/errors	[no test files]
ok  	launchpad.net/juju-core/instance	0.019s
ok  	launchpad.net/juju-core/juju	14.449s
ok  	launchpad.net/juju-core/juju/osenv	0.195s
?   	launchpad.net/juju-core/juju/testing	[no test files]
ok  	launchpad.net/juju-core/log	0.028s
ok  	launchpad.net/juju-core/log/syslog	0.018s
ok  	launchpad.net/juju-core/names	0.032s
?   	launchpad.net/juju-core/provider	[no test files]
?   	launchpad.net/juju-core/provider/all	[no test files]
ok  	launchpad.net/juju-core/provider/azure	4.372s
ok  	launchpad.net/juju-core/provider/dummy	16.663s
ok  	launchpad.net/juju-core/provider/ec2	4.254s
ok  	launchpad.net/juju-core/provider/local	1.215s
?   	launchpad.net/juju-core/provider/local/storage	[no test files]
ok  	launchpad.net/juju-core/provider/maas	2.107s
ok  	launchpad.net/juju-core/provider/openstack	4.017s
ok  	launchpad.net/juju-core/rpc	0.265s
ok  	launchpad.net/juju-core/rpc/jsoncodec	0.230s
ok  	launchpad.net/juju-core/schema	0.018s
ok  	launchpad.net/juju-core/state	61.414s
ok  	launchpad.net/juju-core/state/api	1.370s
ok  	launchpad.net/juju-core/state/api/agent	1.738s
?   	launchpad.net/juju-core/state/api/common	[no test files]
ok  	launchpad.net/juju-core/state/api/deployer	4.740s
ok  	launchpad.net/juju-core/state/api/machiner	2.546s
ok  	launchpad.net/juju-core/state/api/params	0.031s
ok  	launchpad.net/juju-core/state/api/uniter	2.625s
ok  	launchpad.net/juju-core/state/api/upgrader	2.993s
ok  	launchpad.net/juju-core/state/api/watcher	2.935s
ok  	launchpad.net/juju-core/state/apiserver	2.739s
ok  	launchpad.net/juju-core/state/apiserver/agent	2.340s
ok  	launchpad.net/juju-core/state/apiserver/client	16.727s
ok  	launchpad.net/juju-core/state/apiserver/common	0.210s
ok  	launchpad.net/juju-core/state/apiserver/deployer	3.917s
ok  	launchpad.net/juju-core/state/apiserver/machine	3.426s
?   	launchpad.net/juju-core/state/apiserver/testing	[no test files]
ok  	launchpad.net/juju-core/state/apiserver/uniter	12.590s
ok  	launchpad.net/juju-core/state/apiserver/upgrader	3.585s
ok  	launchpad.net/juju-core/state/multiwatcher	0.914s
ok  	launchpad.net/juju-core/state/presence	6.449s
ok  	launchpad.net/juju-core/state/statecmd	0.011s
?   	launchpad.net/juju-core/state/testing	[no test files]
ok  	launchpad.net/juju-core/state/watcher	5.770s
ok  	launchpad.net/juju-core/store	17.854s
ok  	launchpad.net/juju-core/testing	1.355s
ok  	launchpad.net/juju-core/testing/checkers	0.035s
ok  	launchpad.net/juju-core/thirdparty/pbkdf2	0.144s
ok  	launchpad.net/juju-core/tools	0.018s
ok  	launchpad.net/juju-core/upstart	0.113s
ok  	launchpad.net/juju-core/utils	0.973s
ok  	launchpad.net/juju-core/utils/fslock	1.392s
ok  	launchpad.net/juju-core/utils/parallel	0.417s
ok  	launchpad.net/juju-core/utils/set	0.026s
ok  	launchpad.net/juju-core/version	0.061s
ok  	launchpad.net/juju-core/worker	1.606s
ok  	launchpad.net/juju-core/worker/cleaner	1.192s
ok  	launchpad.net/juju-core/worker/deployer	3.108s
ok  	launchpad.net/juju-core/worker/firewaller	10.850s
ok  	launchpad.net/juju-core/worker/machiner	7.180s
ok  	launchpad.net/juju-core/worker/minunitsworker	1.217s
ok  	launchpad.net/juju-core/worker/provisioner	6.233s
ok  	launchpad.net/juju-core/worker/resumer	1.421s
ok  	launchpad.net/juju-core/worker/uniter	129.064s
ok  	launchpad.net/juju-core/worker/uniter/charm	3.547s
ok  	launchpad.net/juju-core/worker/uniter/debug	1.159s
ok  	launchpad.net/juju-core/worker/uniter/hook	0.015s
ok  	launchpad.net/juju-core/worker/uniter/jujuc	0.459s
ok  	launchpad.net/juju-core/worker/uniter/relation	1.329s
ok  	launchpad.net/juju-core/worker/upgrader	2.557s

warning: building out-of-date packages:
	launchpad.net/goamz/ec2/ec2test
	launchpad.net/goamz/s3/s3test
	launchpad.net/goose/testservices/hook
	launchpad.net/goose/testservices/identityservice
	launchpad.net/goose/testservices
	launchpad.net/goose/testservices/novaservice
	launchpad.net/goose/testservices/swiftservice
	launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.

Revision history for this message

Go Bot (go-bot) wrote on 2013-08-28:

Download full text (15.7 KiB)

The attempt to merge lp:~rogpeppe/juju-core/377-fix-server-error into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/agent 0.717s
ok launchpad.net/juju-core/agent/tools 0.243s
ok launchpad.net/juju-core/bzr 6.566s
ok launchpad.net/juju-core/cert 1.995s
ok launchpad.net/juju-core/charm 0.564s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.019s
ok launchpad.net/juju-core/cmd 0.260s
? launchpad.net/juju-core/cmd/builddb [no test files]
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 111.509s

----------------------------------------------------------------------
FAIL: machine_test.go:377: MachineSuite.TestManageStateServesAPI

The attempt to merge lp:~rogpeppe/juju-core/377-fix-server-error into lp:juju-core failed. Below is the output from the failed tests.

ok  	launchpad.net/juju-core/agent	0.717s
ok  	launchpad.net/juju-core/agent/tools	0.243s
ok  	launchpad.net/juju-core/bzr	6.566s
ok  	launchpad.net/juju-core/cert	1.995s
ok  	launchpad.net/juju-core/charm	0.564s
?   	launchpad.net/juju-core/charm/hooks	[no test files]
ok  	launchpad.net/juju-core/cloudinit	0.019s
ok  	launchpad.net/juju-core/cmd	0.260s
?   	launchpad.net/juju-core/cmd/builddb	[no test files]
?   	launchpad.net/juju-core/cmd/charmd	[no test files]
?   	launchpad.net/juju-core/cmd/charmload	[no test files]
ok  	launchpad.net/juju-core/cmd/juju	111.509s

----------------------------------------------------------------------
FAIL: machine_test.go:377: MachineSuite.TestManageStateServesAPI

[LOG] 72.05873 INFO juju environs/testing: uploading FAKE tools 1.13.3-precise-amd64
[LOG] 72.07528 INFO juju.environs.boostrap bootstrapping environment "dummyenv"
[LOG] 72.07530 INFO juju.environs.tools reading tools with major version 1
[LOG] 72.07532 INFO juju.environs.tools filtering tools by version: 1.13.3
[LOG] 72.07533 INFO juju.environs.tools filtering tools by series: precise
[LOG] 72.07534 DEBUG juju.environs.tools reading v1.* tools
[LOG] 72.07535 INFO juju.environs.tools falling back to public bucket
[LOG] 72.07536 DEBUG juju.environs.tools reading v1.* tools
[LOG] 72.07540 DEBUG juju.environs.tools found 1.13.3-precise-amd64
[LOG] 72.07543 INFO juju environs/dummy: would pick tools from 1.13.3-precise-amd64
[LOG] 72.09285 INFO juju.state opening state; mongo addresses: ["localhost:54335"]; entity ""
[LOG] 72.09562 INFO juju.state connection established
[LOG] 72.13277 INFO juju.state initializing environment
[LOG] 72.15874 INFO juju state/api: listening on "127.0.0.1:55356"
[LOG] 72.18266 INFO juju.state opening state; mongo addresses: ["localhost:54335"]; entity ""
[LOG] 72.20454 INFO juju.state connection established
[LOG] 72.20567 INFO juju juju: authorization error while connecting to state server; retrying
[LOG] 72.20576 INFO juju.state opening state; mongo addresses: ["localhost:54335"]; entity ""
[LOG] 72.20930 INFO juju.state connection established
[LOG] 72.24356 INFO juju state/api: dialing "wss://127.0.0.1:55356/"
[LOG] 72.25878 INFO juju state/api: connection established
[LOG] 72.25890 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"user-admin","Password":"dummy-secret","Nonce":""}}
[LOG] 72.25930 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 72.25954 INFO juju.container.lxc lxcObjectFactory replaced with mock lxc factory
[LOG] 72.26078 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"Pinger","Request":"Ping","Params":{}}
[LOG] 72.26084 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Response":{}}
[LOG] 72.34551 INFO juju machine agent machine-0 start
[LOG] 72.35922 INFO juju Starting StateWorker for machine-0
[LOG] 72.35927 INFO juju worker: start "state"
[LOG] 72.35929 INFO juju.state opening state; mongo addresses: ["localhost:54335"]; entity "machine-0"
[LOG] 72.35955 INFO juju worker: start "api"
[LOG] 72.35977 INFO juju state/api: dialing "wss://localhost:39161/"
[LOG] 72.36054 ERROR juju state/api: websocket.Dial wss://localhost:39161/: dial tcp 127.0.0.1:39161: connection refused
[LOG] 72.36058 ERROR juju worker: exited "api": websocket.Dial wss://localhost:39161/: dial tcp 127.0.0.1:39161: connection refused
[LOG] 72.36059 INFO juju worker: restarting "api" in 50ms
[LOG] 72.36253 INFO juju.state connection established
[LOG] 72.39021 INFO juju state/api: dialing "wss://localhost:39161/"
[LOG] 72.39073 INFO juju worker: start "lxc-provisioner"
[LOG] 72.39081 INFO juju worker: start "apiserver"
[LOG] 72.39103 INFO juju state/api: listening on "[::]:39161"
[LOG] 72.41400 INFO juju worker: start "cleaner"
[LOG] 72.41442 INFO juju worker: start "resumer"
[LOG] 72.41461 INFO juju worker: start "minunitsworker"
[LOG] 72.41483 ERROR juju state/api: websocket.Dial wss://localhost:39161/: dial tcp 127.0.0.1:39161: connection refused
[LOG] 72.41486 INFO juju worker: start "api"
[LOG] 72.41508 INFO juju state/api: dialing "wss://localhost:39161/"
[LOG] 72.41939 INFO juju.provisioner Starting up provisioner task 0
[LOG] 72.41959 INFO juju state/api: connection established
[LOG] 72.41970 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"machine-0","Password":"machine-password","Nonce":"user-admin:bootstrap"}}
[LOG] 72.42228 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Response":{}}
[LOG] 72.43622 DEBUG juju rpc/jsoncodec: <- {"RequestId":2,"Type":"Agent","Request":"GetEntities","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 72.43633 DEBUG juju rpc/jsoncodec: <- {"RequestId":3,"Type":"Pinger","Request":"Ping","Params":{}}
[LOG] 72.43679 DEBUG juju rpc/jsoncodec: -> {"RequestId":3,"Response":{}}
[LOG] 72.43704 DEBUG juju rpc/jsoncodec: -> {"RequestId":2,"Response":{"Entities":[{"Life":"alive","Jobs":["JobManageState"],"Error":null}]}}
[LOG] 72.43723 DEBUG juju rpc/jsoncodec: <- {"RequestId":4,"Type":"Agent","Request":"SetPasswords","Params":{"Changes":[{"Tag":"machine-0","Password":"bj4ie530pKH3asLMRC0jCVQr"}]}}
[LOG] 72.44050 DEBUG juju rpc/jsoncodec: -> {"RequestId":4,"Response":{"Results":[{"Error":null}]}}
[LOG] 72.44063 INFO juju worker: start "machiner"
[LOG] 72.44076 INFO juju worker: start "upgrader"
[LOG] 72.44096 DEBUG juju rpc/jsoncodec: <- {"RequestId":5,"Type":"Machiner","Request":"Life","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 72.44103 DEBUG juju rpc/jsoncodec: <- {"RequestId":6,"Type":"Upgrader","Request":"SetTools","Params":{"AgentTools":[{"Tag":"machine-0","Tools":{"Version":"1.13.3-precise-amd64","URL":"http://127.0.0.1:43601/dummyenv/private/tools/juju-1.13.3-precise-amd64.tgz"}}]}}
[LOG] 72.44147 DEBUG juju rpc/jsoncodec: -> {"RequestId":5,"Response":{"Results":[{"Life":"alive","Error":null}]}}
[LOG] 72.44217 DEBUG juju rpc/jsoncodec: <- {"RequestId":7,"Type":"Machiner","Request":"SetStatus","Params":{"Entities":[{"Tag":"machine-0","Status":"started","Info":""}],"Machines":null}}
[LOG] 72.44591 DEBUG juju rpc/jsoncodec: -> {"RequestId":6,"Response":{"Results":[{"Error":null}]}}
[LOG] 72.44660 DEBUG juju rpc/jsoncodec: <- {"RequestId":8,"Type":"Upgrader","Request":"WatchAPIVersion","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 72.44700 DEBUG juju rpc/jsoncodec: -> {"RequestId":8,"Response":{"Results":[{"NotifyWatcherId":"2","Error":null}]}}
[LOG] 72.44768 DEBUG juju rpc/jsoncodec: <- {"RequestId":9,"Type":"Upgrader","Request":"Tools","Params":{"Entities":[{"Tag":"machine-0"}]}}
[LOG] 72.44774 DEBUG juju rpc/jsoncodec: <- {"RequestId":10,"Type":"NotifyWatcher","Id":"2","Request":"Next","Params":{}}
[LOG] 72.44922 INFO juju state/api: dialing "wss://localhost:39161/"
[LOG] 72.44975 INFO juju.environs.tools finding exact version 1.13.3-precise-amd64
[LOG] 72.44976 INFO juju.environs.tools reading tools with major version 1
[LOG] 72.44977 INFO juju.environs.tools filtering tools by version: 1.13.3
[LOG] 72.44978 INFO juju.environs.tools filtering tools by series: precise
[LOG] 72.44979 INFO juju.environs.tools filtering tools by architecture: amd64
[LOG] 72.44980 DEBUG juju.environs.tools reading v1.* tools
[LOG] 72.44983 DEBUG juju.environs.tools found 1.13.3-precise-amd64
[LOG] 72.44990 DEBUG juju rpc/jsoncodec: -> {"RequestId":9,"Response":{"Results":[{"Tools":{"Version":"1.13.3-precise-amd64","URL":"http://127.0.0.1:43601/dummyenv/private/tools/juju-1.13.3-precise-amd64.tgz"},"Error":null}]}}
[LOG] 72.45004 INFO juju.worker.upgrader required tools: 1.13.3-precise-amd64
[LOG] 72.45282 INFO juju state/api: connection established
[LOG] 72.45291 DEBUG juju rpc/jsoncodec: <- {"RequestId":1,"Type":"Admin","Request":"Login","Params":{"AuthTag":"machine-0","Password":"machine-password","Nonce":"user-admin:bootstrap"}}
[LOG] 72.45367 DEBUG juju rpc/jsoncodec: -> {"RequestId":1,"Error":"invalid entity name or password","ErrorCode":"unauthorized access","Response":{}}
machine_test.go:385:
    s.assertJobWithState(c, state.JobManageState, func(conf agent.Config, agentState *state.State) {
        st, _, err := conf.OpenAPI(fastDialOpts)
        c.Assert(err, gc.IsNil)
        defer st.Close()
        m, err := st.Machiner().Machine(conf.Tag())
        c.Assert(err, gc.IsNil)
        c.Assert(m.Life(), gc.Equals, params.Alive)
    })
machine_test.go:380:
    c.Assert(err, gc.IsNil)
... value *params.Error = &params.Error{"unauthorized access", "invalid entity name or password"} ("invalid entity name or password")

[LOG] 72.45953 DEBUG juju worker: killing runner 0xc2002e5ae0
[LOG] 72.45962 INFO juju worker: runner is dying
[LOG] 72.45963 DEBUG juju worker: killing "state"
[LOG] 72.45964 DEBUG juju worker: killing runner 0xc20038c4e0
[LOG] 72.45965 DEBUG juju worker: killing "api"
[LOG] 72.45966 DEBUG juju worker: killing runner 0xc200cd2ae0
[LOG] 72.45967 INFO juju worker: runner is dying
[LOG] 72.45968 DEBUG juju worker: killing "lxc-provisioner"
[LOG] 72.45969 DEBUG juju worker: killing "apiserver"
[LOG] 72.45970 DEBUG juju worker: killing "cleaner"
[LOG] 72.45972 DEBUG juju worker: killing "resumer"
[LOG] 72.45973 DEBUG juju worker: killing "minunitsworker"
[LOG] 72.45974 INFO juju worker: runner is dying
[LOG] 72.45975 DEBUG juju worker: killing "machiner"
[LOG] 72.45976 DEBUG juju worker: killing "upgrader"
[LOG] 72.45989 INFO juju.provisioner Shutting down provisioner task 0
[LOG] 72.46021 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:39425: use of closed network connection (closing true)
[LOG] 72.46043 DEBUG juju rpc/jsoncodec: <- {"RequestId":11,"Type":"NotifyWatcher","Id":"2","Request":"Stop","Params":{}}
[LOG] 72.48081 DEBUG juju rpc/jsoncodec: -> {"RequestId":7,"Response":{"Results":[{"Error":null}]}}
[LOG] 72.48140 DEBUG juju rpc/jsoncodec: -> {"RequestId":10,"Error":"watcher has been stopped","ErrorCode":"stopped","Response":{}}
[LOG] 72.48202 DEBUG juju rpc/jsoncodec: -> {"RequestId":11,"Error":"connection is shut down","Response":{}}
[LOG] 72.48435 INFO juju.worker.machiner "machine-0" started
[LOG] 72.48450 ERROR juju state/api: error trying to stop watcher connection is shut down
[LOG] 72.48462 ERROR juju worker: fatal "machiner": connection is shut down
[LOG] 72.48526 ERROR juju worker: exited "api": connection is shut down
[LOG] 72.48543 INFO juju.container.lxc lxcObjectFactory replaced with &{}
[LOG] 72.48772 INFO juju environs/dummy: reset environment
[LOG] 72.48814 DEBUG juju rpc/jsoncodec: <- error: read tcp 127.0.0.1:42297: use of closed network connection (closing true)
[jujuc whatever]
[remote]
[/path/to/remote]
[remote --help]
[unknown]
[remote --error borken]
[remote --unknown]
[remote unwanted]
OOPS: 31 passed, 3 skipped, 1 FAILED
--- FAIL: TestPackage (36.59 seconds)
FAIL
FAIL	launchpad.net/juju-core/cmd/jujud	36.862s
ok  	launchpad.net/juju-core/cmd/plugins/juju-metadata	1.371s
ok  	launchpad.net/juju-core/constraints	0.031s
ok  	launchpad.net/juju-core/container/lxc	0.336s
?   	launchpad.net/juju-core/container/lxc/mock	[no test files]
ok  	launchpad.net/juju-core/downloader	5.282s
ok  	launchpad.net/juju-core/environs	1.177s
ok  	launchpad.net/juju-core/environs/bootstrap	0.010s
ok  	launchpad.net/juju-core/environs/cloudinit	0.449s
ok  	launchpad.net/juju-core/environs/config	0.747s
ok  	launchpad.net/juju-core/environs/imagemetadata	0.322s
ok  	launchpad.net/juju-core/environs/instances	0.227s
ok  	launchpad.net/juju-core/environs/jujutest	0.206s
ok  	launchpad.net/juju-core/environs/localstorage	0.279s
ok  	launchpad.net/juju-core/environs/simplestreams	0.259s
?   	launchpad.net/juju-core/environs/simplestreams/testing	[no test files]
ok  	launchpad.net/juju-core/environs/sync	0.298s
ok  	launchpad.net/juju-core/environs/testing	0.010s
ok  	launchpad.net/juju-core/environs/tools	23.472s
?   	launchpad.net/juju-core/errors	[no test files]
ok  	launchpad.net/juju-core/instance	0.019s
ok  	launchpad.net/juju-core/juju	14.316s
ok  	launchpad.net/juju-core/juju/osenv	0.218s
?   	launchpad.net/juju-core/juju/testing	[no test files]
ok  	launchpad.net/juju-core/log	0.019s
ok  	launchpad.net/juju-core/log/syslog	0.026s
ok  	launchpad.net/juju-core/names	0.017s
?   	launchpad.net/juju-core/provider	[no test files]
?   	launchpad.net/juju-core/provider/all	[no test files]
ok  	launchpad.net/juju-core/provider/azure	4.422s
ok  	launchpad.net/juju-core/provider/dummy	16.795s
ok  	launchpad.net/juju-core/provider/ec2	4.374s
ok  	launchpad.net/juju-core/provider/local	1.277s
?   	launchpad.net/juju-core/provider/local/storage	[no test files]
ok  	launchpad.net/juju-core/provider/maas	2.098s
ok  	launchpad.net/juju-core/provider/openstack	3.885s
ok  	launchpad.net/juju-core/rpc	0.266s
ok  	launchpad.net/juju-core/rpc/jsoncodec	0.238s
ok  	launchpad.net/juju-core/schema	0.017s
ok  	launchpad.net/juju-core/state	61.357s
ok  	launchpad.net/juju-core/state/api	1.269s
ok  	launchpad.net/juju-core/state/api/agent	1.775s
?   	launchpad.net/juju-core/state/api/common	[no test files]
ok  	launchpad.net/juju-core/state/api/deployer	4.820s
ok  	launchpad.net/juju-core/state/api/machiner	2.539s
ok  	launchpad.net/juju-core/state/api/params	0.029s
ok  	launchpad.net/juju-core/state/api/uniter	2.788s
ok  	launchpad.net/juju-core/state/api/upgrader	2.928s
ok  	launchpad.net/juju-core/state/api/watcher	2.837s
ok  	launchpad.net/juju-core/state/apiserver	2.741s
ok  	launchpad.net/juju-core/state/apiserver/agent	2.428s
ok  	launchpad.net/juju-core/state/apiserver/client	17.024s
ok  	launchpad.net/juju-core/state/apiserver/common	0.251s
ok  	launchpad.net/juju-core/state/apiserver/deployer	3.960s
ok  	launchpad.net/juju-core/state/apiserver/machine	3.448s
?   	launchpad.net/juju-core/state/apiserver/testing	[no test files]
ok  	launchpad.net/juju-core/state/apiserver/uniter	12.782s
ok  	launchpad.net/juju-core/state/apiserver/upgrader	3.689s
ok  	launchpad.net/juju-core/state/multiwatcher	1.094s
ok  	launchpad.net/juju-core/state/presence	6.551s
ok  	launchpad.net/juju-core/state/statecmd	0.010s
?   	launchpad.net/juju-core/state/testing	[no test files]
ok  	launchpad.net/juju-core/state/watcher	5.841s
ok  	launchpad.net/juju-core/store	18.443s
ok  	launchpad.net/juju-core/testing	1.354s
ok  	launchpad.net/juju-core/testing/checkers	0.027s
ok  	launchpad.net/juju-core/thirdparty/pbkdf2	0.134s
ok  	launchpad.net/juju-core/tools	0.018s
ok  	launchpad.net/juju-core/upstart	0.132s
ok  	launchpad.net/juju-core/utils	1.044s
ok  	launchpad.net/juju-core/utils/fslock	1.507s
ok  	launchpad.net/juju-core/utils/parallel	0.419s
ok  	launchpad.net/juju-core/utils/set	0.023s
ok  	launchpad.net/juju-core/version	0.058s
ok  	launchpad.net/juju-core/worker	1.518s
ok  	launchpad.net/juju-core/worker/cleaner	1.258s
ok  	launchpad.net/juju-core/worker/deployer	8.238s
ok  	launchpad.net/juju-core/worker/firewaller	11.193s
ok  	launchpad.net/juju-core/worker/machiner	7.321s
ok  	launchpad.net/juju-core/worker/minunitsworker	1.287s
ok  	launchpad.net/juju-core/worker/provisioner	6.409s
ok  	launchpad.net/juju-core/worker/resumer	1.407s
ok  	launchpad.net/juju-core/worker/uniter	125.641s
ok  	launchpad.net/juju-core/worker/uniter/charm	3.048s
ok  	launchpad.net/juju-core/worker/uniter/debug	2.127s
ok  	launchpad.net/juju-core/worker/uniter/hook	0.014s
ok  	launchpad.net/juju-core/worker/uniter/jujuc	0.442s
ok  	launchpad.net/juju-core/worker/uniter/relation	1.365s
ok  	launchpad.net/juju-core/worker/upgrader	2.455s

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Aaron Bentley

Dave Cheney

Dimiter Naydenov

Eric Snow

John A Meinel

Martin Packman

Nate Finch

Raphaël Badin

Roger Peppe

Tim Penhey

to status/vote changes:

rowez

1	=== modified file 'state/apiserver/common/errors.go'
2	--- state/apiserver/common/errors.go 2013-08-06 17:09:11 +0000
3	+++ state/apiserver/common/errors.go 2013-08-28 09:13:33 +0000
4	@@ -51,6 +51,17 @@
5	ErrNotProvisioned: params.CodeNotProvisioned,
6	}
7
8	+func singletonCode(err error) (string, bool) {
9	+ // All error types may not be hashable; deal with
10	+ // that by catching the panic if we try to look up
11	+ // a non-hashable type.
12	+ defer func() {
13	+ recover()
14	+ }()
15	+ code, ok := singletonErrorCodes[err]
16	+ return code, ok
17	+}
18	+
19	// ServerError returns an error suitable for returning to an API
20	// client, with an error code suitable for various kinds of errors
21	// generated in packages outside the API.
22	@@ -58,9 +69,9 @@
23	if err == nil {
24	return nil
25	}
26	- code := singletonErrorCodes[err]
27	+ code, ok := singletonCode(err)
28	switch {
29	- case code != "":
30	+ case ok:
31	case errors.IsUnauthorizedError(err):
32	code = params.CodeUnauthorized
33	case errors.IsNotFoundError(err):
34
35	=== renamed file 'state/apiserver/errors_test.go' => 'state/apiserver/common/errors_test.go'
36	--- state/apiserver/errors_test.go 2013-08-19 11:20:02 +0000
37	+++ state/apiserver/common/errors_test.go 2013-08-28 09:13:33 +0000
38	@@ -1,7 +1,7 @@
39	// Copyright 2012, 2013 Canonical Ltd.
40	// Licensed under the AGPLv3, see LICENCE file for details.
41
42	-package apiserver_test
43	+package common_test
44
45	import (
46	stderrors "errors"
47	@@ -71,10 +71,19 @@
48	err: stderrors.New("an error"),
49	code: "",
50	}, {
51	+ err: unhashableError{"foo"},
52	+ code: "",
53	+}, {
54	err: nil,
55	code: "",
56	}}
57
58	+type unhashableError []string
59	+
60	+func (err unhashableError) Error() string {
61	+ return err[0]
62	+}
63	+
64	func (s errorsSuite) TestErrorTransform(c gc.C) {
65	for _, t := range errorTransformTests {
66	err1 := common.ServerError(t.err)