Code review comment for lp:~rogpeppe/juju-core/313-jsoncodec-optional-log

Revision history for this message
Roger Peppe (rogpeppe) wrote :

Please take a look.

https://codereview.appspot.com/9692044/diff/5002/rpc/jsoncodec/codec.go
File rpc/jsoncodec/codec.go (right):

https://codereview.appspot.com/9692044/diff/5002/rpc/jsoncodec/codec.go#newcode44
rpc/jsoncodec/codec.go:44: // called before the codec is used for
serving RPC requests.
On 2013/05/27 20:29:44, fwereade wrote:
> This is a timebomb that will explode as soon as we have dynamic
logging levels,
> and someone notices that the API server doesn't respect them. If
you're going to
> implement this, please do it properly...

Done.

https://codereview.appspot.com/9692044/

« Back to merge proposal