Code review comment for lp:~rogpeppe/juju-core/313-jsoncodec-optional-log

Revision history for this message
Roger Peppe (rogpeppe) wrote :

Reviewers: mp+165736_code.launchpad.net,

Message:
Please take a look.

Description:
rpc/jsoncodec: optional logging

Because we're now using the same codec on
both client and server, we were seeing each message
logged twice when testing. This changes
things so we only log on the server side.

https://code.launchpad.net/~rogpeppe/juju-core/313-jsoncodec-optional-log/+merge/165736

Requires:
https://code.launchpad.net/~rogpeppe/juju-core/312-api-jobs/+merge/165705

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9692044/

Affected files:
   A [revision details]
   M rpc/jsoncodec/codec.go
   M rpc/jsoncodec/codec_test.go
   M rpc/jsoncodec/conn.go
   M state/apiserver/apiserver.go

« Back to merge proposal