NOT LGTM. Int jobs aren't great, but they're better than baking bad names into the API forever, I think.
https://codereview.appspot.com/9754043/diff/13001/state/machine.go File state/machine.go (right):
https://codereview.appspot.com/9754043/diff/13001/state/machine.go#newcode38 state/machine.go:38: // jobNames MUST NEVER BE CHANGED.
...or maybe we could just use ints, as designed originally, and not lumber the API with guaranteed-inaccurate names. (JobServeAPI is not sensible; it conflates jobs with tasks.)
https://codereview.appspot.com/9754043/
« Back to merge proposal
NOT LGTM. Int jobs aren't great, but they're better than baking bad
names into the API forever, I think.
https:/ /codereview. appspot. com/9754043/ diff/13001/ state/machine. go
File state/machine.go (right):
https:/ /codereview. appspot. com/9754043/ diff/13001/ state/machine. go#newcode38 go:38:
state/machine.
// jobNames MUST NEVER BE CHANGED.
...or maybe we could just use ints, as designed originally, and not inaccurate names. (JobServeAPI is not
lumber the API with guaranteed-
sensible; it conflates jobs with tasks.)
https:/ /codereview. appspot. com/9754043/