juju-core

Code review comment for lp:~rogpeppe/juju-core/213-rpc-test-timeouts

  1. 213-rpc-test-timeouts
  2. Merge into trunk
Revision history for this message
William Reade (fwereade) wrote :

LGTM, one suggestion

https://codereview.appspot.com/7324046/diff/2001/rpc/rpc_test.go
File rpc/rpc_test.go (right):

https://codereview.appspot.com/7324046/diff/2001/rpc/rpc_test.go#newcode277
rpc/rpc_test.go:277: case <-time.After(3 * time.Second):
Can we reasonably drop this to, say, half a second?

https://codereview.appspot.com/7324046/

« Back to merge proposal