Code review comment for lp:~rogpeppe/juju-core/213-rpc-test-timeouts

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-02-13 16:40, Dimiter Naydenov wrote:
> LGTM
>
> https://codereview.appspot.com/7324046/
>

LGTM

I can confirm that it makes the tests fail quickly rather than hang
until the 5min timeout.

Of course, better if they didn't fail, but this is still an
improvement. :)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlEbiyQACgkQJdeBCYSNAAPYNQCgu/8iZnXoGba5+RMHDdo3XQoE
PYEAnRco0W3eMPh1BunHCHQ/DjYulkvF
=oBYC
-----END PGP SIGNATURE-----

« Back to merge proposal