Code review comment for lp:~rogpeppe/juju-core/041-config-agent-version

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

LGTM

https://codereview.appspot.com/6499055/diff/2001/environs/config/config.go
File environs/config/config.go (right):

https://codereview.appspot.com/6499055/diff/2001/environs/config/config.go#newcode95
environs/config/config.go:95: panic(err) // We should have checked it
earlier.
s/should have//

The long spacing between the panic and the comment makes it harder to
read.

https://codereview.appspot.com/6499055/diff/2001/environs/config/config.go#newcode136
environs/config/config.go:136: "agent-version": schema.String(),
go fmt

https://codereview.appspot.com/6499055/diff/2001/schema/schema.go
File schema/schema.go (right):

https://codereview.appspot.com/6499055/diff/2001/schema/schema.go#newcode326
schema/schema.go:326: // missing field will be omitted from the coerced
map.
Cheers!

https://codereview.appspot.com/6499055/

« Back to merge proposal