Code review comment for lp:~rogpeppe/gozk/update-server-interface

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

[10]

+// exist, it assumes the server is not running and returns (nil, nil).

This interface is strange, and can easily lead to bugs since it's not an idiom in Go.
I'd never assume p is nil if err == nil. Please return an error if p == nil.

« Back to merge proposal