Code review comment for lp:~rogpeppe/gozk/update-event-interface

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

2692 - event := Event{
2693 - Type: int(data.event_type),
2694 - Path: C.GoString(data.event_path),
2695 - State: int(data.connection_state),
2696 - }

The key problem with this proposal is the trashing of information coming
from the server. It's discarding not only why e.g. a state is being
trashed, but also details like the path which is related to an event.
This path isn't just being returned from the path that called the watch.
It's actually part of the wire protocol, and comes from the server side.

Trashing both the session state error information and the paths like that
is not a good idea.

review: Disapprove

« Back to merge proposal