Code review comment for lp:~rogpeppe/gozk/comments-and-time
Revision history for this message
| Roger Peppe (rogpeppe) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
PTAL
https:/
File zk.go (right):
https:/
zk.go:97: // event.
On 2012/02/13 13:53:57, niemeyer wrote:
> This is extremely redundant. Please use something along these lines
instead:
> type Event struct {
> Type int // One of the EVENT_* constants
> Path string // Node path for non-session events
> State int // One of the STATE_* constants
> }
> Note that State exists for non-session events also.
Done.
https:/
zk.go:347: // CVersion returns the number of changes to the children of
the node.
On 2012/02/13 13:53:57, niemeyer wrote:
> This needs clarification. Will a change in a child's data increase
this version
> too?
Done.
https:/
zk.go:368: // NumChildren returns the number of children of the znode.
On 2012/02/13 13:53:57, niemeyer wrote:
> s/znode/node/, as everywhere else.
Done.
https:/
File zk_test.go (right):
https:/
zk_test.go:187: if dt < 0 || dt > maxdt {
On 2012/02/13 13:53:57, niemeyer wrote:
> if t.Before(t0) || t.After(t1) {
doh!
https:/