Code review comment for lp:~rogpeppe/gozk/clean-up-interface

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Thanks for the changes. Some additional feedback:

[10]

> i thought quite a bit about this.
> the problem with doing the starting ourselves is that
> there are many things the caller might wish to do

Yeah, we talked precisely about this on IRC. None of the
points you mention are a good reason to not provide the
suggested interface.

[12]

> the docs say that the only error that glob can return is if the
> pattern is malformed. those patterns are evidently not.

Until someone changes them by mistake and they become malformed,
and rather than being warned about that we get crazy behavior.

A panic is fine in that case, but please do not leave errors unchecked.

[14]

Sounds good.

« Back to merge proposal