Code review comment for lp:~rogpeppe/goyaml/goyaml-omit-zero-pointers

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Nice, LGTM

https://codereview.appspot.com/5431087/diff/1/goyaml.go
File goyaml.go (right):

https://codereview.appspot.com/5431087/diff/1/goyaml.go#newcode266
goyaml.go:266: return v.IsNil()
You can join this to the above Interface case:

     case reflect.Ptr, reflect.Interface:
         ...

https://codereview.appspot.com/5431087/

« Back to merge proposal