Code review comment for lp:~rogpeppe/goose/state-of-the-world

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...

>> This one is actually part of the public api. Though AuthLegacy
>> would
> be ok.
>
> yeah, i saw that. although, given that the auth method is an
> argument to NewOpenStackClient, perhaps it wouldn't be unreasonable
> to ask clients to pass in an auth method value themselves, rather
> than a constant that implies one. alternatively, you could make
> these constants of a type that has a Method() Authenticator
> method.
>
> requiring external clients to enumerate all the possible auth
> methods when we can easily make the linkage here seems somewhat
> unnecessary.
>
> i'm probably missing something crucial though.
>

Ultimately the auth that we pick has to come from the
environments.yaml file. Because it depends heavily on what openstack
cloud we are connecting to. (HP's auth is different from Rackspace, is
different from Canonistack, etc.)

So ideally the outside-of-goose level would just be a string request
of an auth to use, of a specific set of enumerated constants.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Cygwin)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlC0QPcACgkQJdeBCYSNAANURwCgzxS64UxSnFL2spmLcUEbtKPI
7Q4AoLlK1FjFBaLcHgdxoaARbM193kSx
=COy9
-----END PGP SIGNATURE-----