Code review comment for lp:~rogpeppe/gocheck/add-list-flag

https://codereview.appspot.com/5705044/diff/2002/gocheck.go
File gocheck.go (left):

https://codereview.appspot.com/5705044/diff/2002/gocheck.go#oldcode554
gocheck.go:554: filterRegexp.MatchString(suiteName+"."+testName))
On 2012/02/28 14:17:27, niemeyer wrote:
> We can't change the behavior of .f before the next announced release.

FWIW the new behaviour is exactly the old behaviour if the user doesn't
use ^ or $ in their regexp. none of the tests needed to change, which is
a useful indicator.

i'll revert nonetheless.

https://codereview.appspot.com/5705044/diff/2002/run.go
File run.go (right):

https://codereview.appspot.com/5705044/diff/2002/run.go#newcode28
run.go:28: "Regular expression selecting what to run (use -gocheck.list
to see what this matches against)")
On 2012/02/28 14:17:27, niemeyer wrote:
> Please revert this. -gocheck.list is documented below already.

AFAIK the text that the regexp matches is not documented anywhere (for
instance i didn't know that you could filter on a suite name until i
read the source code). if this isn't a reasonable place to document the
behaviour, perhaps you could suggest another.

https://codereview.appspot.com/5705044/diff/2002/run_test.go
File run_test.go (right):

https://codereview.appspot.com/5705044/diff/2002/run_test.go#newcode296
run_test.go:296: "*gocheck_test.FixtureHelper.Test2",
On 2012/02/28 14:17:27, niemeyer wrote:
> What is this "*" doing there?

the method is on a pointer type. i've found this info useful in the
past. perhaps it shouldn't be indicated though.

https://codereview.appspot.com/5705044/