Code review comment for lp:~roger-lp/ladon/trunk

Revision history for this message
jsgaarde (jakob-simon-gaarde) wrote :

OK, so this is a fix Python 3.3+? good :-)

> If there are not check for '__qualname__' when I run ladon application using
> python 3.3 I get following exception for any exposed with ladonize method:
>
> Traceback (most recent call last):
> File "/home/roger/projects/ladon/frameworks/python/tests/ladon/server/wsgi_a
> pplication.py", line 318, in __call__
> self.import_services(self.service_list)
> File "/home/roger/projects/ladon/frameworks/python/tests/ladon/server/wsgi_a
> pplication.py", line 274, in import_services
> __import__(service)
> File "/home/roger/projects/ladon/frameworks/python/tests/services/attachment
> tests.py", line 23, in <module>
> class AttachmentTestService(object):
> File "/home/roger/projects/ladon/frameworks/python/tests/services/attachment
> tests.py", line 30, in AttachmentTestService
> @ladonize(File,rtype=UploadFileResponse)
> File "/home/roger/projects/ladon/frameworks/python/tests/ladon/ladonizer/dec
> orator.py", line 88, in decorator
> ladon_method_info =
> global_service_collection().add_service_method(f,*def_args,**def_kw)
> File "/home/roger/projects/ladon/frameworks/python/tests/ladon/ladonizer/col
> lection.py", line 133, in add_service_method
> method =
> self.services[(src_fname,clsname)].add_method(f,*def_args,**def_kw)
> File "/home/roger/projects/ladon/frameworks/python/tests/ladon/ladonizer/col
> lection.py", line 325, in add_method
> method = LadonMethodInfo(self,f,*def_args,**def_kw)
> File "/home/roger/projects/ladon/frameworks/python/tests/ladon/ladonizer/col
> lection.py", line 507, in __init__
> self._multipart_response_required =
> sinfo.typemanager.analyze_param(self._rtype)
> File "/home/roger/projects/ladon/frameworks/python/tests/ladon/types/typeman
> ager.py", line 158, in analyze_param
> self.analyze_class(param)
> File "/home/roger/projects/ladon/frameworks/python/tests/ladon/types/typeman
> ager.py", line 116, in analyze_class
> raise NeedToDefineParseTimeException("class attributes on LadonTypes must
> be defined as types, lists.\\nclass: %s\\nattr: %s" %
> (cls.__name__,attr))\nladon.exceptions.types.NeedToDefineParseTimeException:
> class attributes on LadonTypes must be defined as types, lists.
> class: UploadFileResponse\nattr: __qualname__

« Back to merge proposal