Code review comment for lp:~roederhr/revager/dmgbuild

Revision history for this message
Johannes Wettinger (jojow) wrote :

I've tried the build script on Mac OS X Leopard. At first glance it seems to work very well, so you get a functional DMG file. The problem is that you get a usual DMG without the artwork. I don't know what exactly the problem is, but there is an error concerning Finder and the "RevAger" disk. Here you can see the output of Ant:

build-dmg:
   [delete] Could not find file /Users/jojo/Desktop/dmgbuild/dist/RevAger_1.2.dmg to delete.
     [exec] created: /Users/jojo/Desktop/dmgbuild/dist/RevAger-tmp.dmg
     [exec] /dev/disk1 Apple_partition_scheme
     [exec] /dev/disk1s1 Apple_partition_map
     [exec] /dev/disk1s2 Apple_HFS /tmp/RevAger
    [mkdir] Created dir: /tmp/RevAger/.background
     [copy] Copying 1 file to /tmp/RevAger/.background
     [exec] /Users/jojo/Desktop/dmgbuild/src/neos/resi/resources/build/macosx/dmg_setlayout.applescript:167:171: execution error: Finder got an error: Can’t get disk "RevAger". (-1728)
     [exec] Result: 1
     [exec] "disk1" unmounted.
     [exec] "disk1" ejected.
     [exec] Image-Funktion vorbereiten …
     [exec] Driver Descriptor Map (DDM : 0) lesen …
     [exec] (CRC32 $136CED08: Driver Descriptor Map (DDM : 0))
     [exec] Apple (Apple_partition_map : 1) lesen …
     [exec] (CRC32 $E1D68E7C: Apple (Apple_partition_map : 1))
     [exec] disk image (Apple_HFS : 2) lesen …
     [exec] (CRC32 $9044734A: disk image (Apple_HFS : 2))
     [exec] (Apple_Free : 3) lesen …
     [exec] (CRC32 $00000000: (Apple_Free : 3))
     [exec] Ressourcen hinzufügen …
     [exec] Dauer: 863.429ms
     [exec] Dateigröße: 8617544 Bytes, Prüfsumme: CRC32 $1C7850D3
     [exec] Bearbeitete Sektoren: 37906, 34977 komprimiert
     [exec] Geschwindigkeit: 19.8M Bytes/Sek
     [exec] Ersparnis: 55.6 %
     [exec] created: /Users/jojo/Desktop/dmgbuild/dist/RevAger_1.2.dmg
   [delete] Deleting: /Users/jojo/Desktop/dmgbuild/dist/RevAger-tmp.dmg

BUILD SUCCESSFUL
Total time: 20 seconds

review: Needs Fixing (schreibtischtest)

« Back to merge proposal