Code review comment for ~rodrigo-zaiden/ubuntu-cve-tracker:kernel_usn_option

Revision history for this message
Rodrigo Figueiredo Zaiden (rodrigo-zaiden) wrote :

Hi Seth,

> The name feels a bit generic for what it does; if there's a good reason to go
> with this, that's fine, but I'd like to suggest something more like:
>
> --ignore-released-cves
> --filter-released-cves
> --skip-released-cves
> --ignore-released-cves-in-changelog
> --filter-released-cves-in-changelog
> --skip-released-cves-in-changelog
>
> or something else :) -- something that's more specific about what exact
> operation is going to be done, and the cves that it is going to be done to.

Thanks for the input, better be clear.
I got one of your ideas (--ignore-released-cves-in-changelog) and added in a new commit alongside with a fix for a condition that I just realized it was missing.

>
> Thanks

Thank you very much

« Back to merge proposal