Code review comment for ~rodrigo-zaiden/ubuntu-cve-tracker:generate_usn_grepping

Revision history for this message
Spyros Seimenis (sespiros) wrote :

I agree with Alex, I thought the purpose of adding that regex check was to force someone to look at the XXX in the commented lines (in addition to making sure that no placeholder XXX text has been forgotten in a description). Instead of ignoring those specific 3 cases why not:
- XXX-EXPAND-TO-UPSTREAM-NAME-XXX, automate that step instead of requiring a manual check
- XXX-CHECK-XXX not sure if that can be automated

or simply use 2 different identifiers, for example XXX for placeholder texts and TODO/MANUALCHECK/whatever, for those commented lines that simply require manual intervention.

« Back to merge proposal