Code review comment for ~rodrigo-zaiden/ubuntu-cve-tracker:security-signoff-add-assignee

Revision history for this message
Rodrigo Figueiredo Zaiden (rodrigo-zaiden) wrote :

Update:
Gave a better attention to this topic, and, first of all, there is no such
thing as having a bug reported in the `kernel-sru-check` with
"Verification-testing" as "Invalid" and needing Security Signoff, I was
probably misreading the bug, sorry for that.

So, considering that the output of `kernel-sru-check` is already updating
the status to "In Progress" and assigning the bug for the person that is
running the script, there is no need (and probably does not make sense)
to change the assignee in `kernel-security-signoff.py`.

When I proposed this merge, I was simply running `kernel-sru-check` and
ACKing or NCKing the outputs, and what I wanted was to update the assignee
as it was assigned to the person that ran `kernel-sru-check` in the first
place.

Now, I think that, better than just changing the assignee when actually
doing the signoff, we could review when we update the status and assignee
in the `kernel-sru-check` script when we have more than one person running
it, specially if it runs in cron jobs and doesn't necessarily means that
the person running the script is working on it.

I'll reject this merge, any ideas or thoughts on the internal process of
assigning and changing status is really welcomed.
Thanks!

« Back to merge proposal