Merge ~rodrigo-zaiden/qa-regression-testing:change-qrt-alternates-readme into qa-regression-testing:master
Status: | Merged |
---|---|
Merged at revision: | b15fd3d897d52d02cd890738bbb461f097072eee |
Proposed branch: | ~rodrigo-zaiden/qa-regression-testing:change-qrt-alternates-readme |
Merge into: | qa-regression-testing:master |
Diff against target: |
17 lines (+5/-4) 1 file modified
scripts/README (+5/-4) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Murray | Approve | ||
Review via email: mp+418551@code.launchpad.net |
Commit message
README: Change QRT-Alternates flag definition
QRT-Alternates does not stop at first successful installation,
instead it goes through the whole list. It has the ability to
specify the package to be installed according to the release.
Also adding a note to try to keep one line per package
specification for a better maintainability.
Description of the change
At a first glance, from the README, one may understand that QRT-Alternates can be used to try to install a package and stop when the first one on the list is successful installed, but `scripts/
for pkg in to_install:
tmp = pkg.split(':')
pkg = tmp[0]
if pkg in skipped:
if install(pkg):
If we change the last `continue` to `break` it could do the trick, but it would break at least one existing script, such as `scripts/
Briefly discussed with Alex Murray that suggested a change in the README instead of changing the packages-helper and consequentially having to change (and test) all scripts using it differently, with a potential risk of breaking things without a really well defined gain.
So, updated the README to remove the "stop at first successful installation" and added a note on the <pkg>:<release> alternation support.
Suggestions are more than welcome.
Thanks Alex and everyone looking.
LGTM! Thanks.