Code review comment for lp:~rodrigo-moya/unity/indicators-a11y

Revision history for this message
Alejandro PiƱeiro (apinheiro) wrote :

Seems ok, just some nitpicks:

83 + return (AtkObject *) pia;
287 + return (AtkObject *) piea;

why don't use the usual gobject macros ATK_OBJECT (pia)?

Anyway, then, when I tested it, I found this warning messages:

[gshell-devel]@remigio:~/a11y-scripts$ python dump_tree.py

** (process:9834): WARNING **: AT-SPI: Accessibility bus not found - Using session bus.

Index: 0
Application name: unity-panel-service
** (unity-panel-service:9294): DEBUG: PanelRootAccessible has 5 children
Application elements: 5
** (unity-panel-service:9294): DEBUG: PanelRootAccessible has 5 children

(unity-panel-service:9294): GLib-GObject-WARNING **: g_type_instance_get_private() requires a prior call to g_type_class_add_private()
** (unity-panel-service:9294): DEBUG: Returning ATK child 0x8d3a190
 -- Role: label Name: An indicator

(unity-panel-service:9294): GLib-GObject-WARNING **: g_type_instance_get_private() requires a prior call to g_type_class_add_private()
** (unity-panel-service:9294): DEBUG: Returning ATK child 0x8d3d990
 -- Role: label Name: An indicator

(unity-panel-service:9294): GLib-GObject-WARNING **: g_type_instance_get_private() requires a prior call to g_type_class_add_private()
** (unity-panel-service:9294): DEBUG: Returning ATK child 0x8bd6d18
 -- Role: label Name: An indicator

(unity-panel-service:9294): GLib-GObject-WARNING **: g_type_instance_get_private() requires a prior call to g_type_class_add_private()
** (unity-panel-service:9294): DEBUG: Returning ATK child 0x8d3a340
 -- Role: label Name: An indicator

(unity-panel-service:9294): GLib-GObject-WARNING **: g_type_instance_get_private() requires a prior call to g_type_class_add_private()
** (unity-panel-service:9294): DEBUG: Returning ATK child 0x8bd6c28
 -- Role: label Name: An indicator

I used a custom script, but I also see them using accerciser.

review: Needs Fixing

« Back to merge proposal