Code review comment for lp:~rodrigo-moya/ubuntuone-client/share-my-picked-contacts

Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

> This has a memory leak: the list returned by e_contact_get_attributes needs to
> be freed by the caller. (The individual attribute objects don't -- they're
> still owned by the contact object.)

right, fixed. But the individual attribute objects are also owned by the caller, so added code to free them both

« Back to merge proposal