Code review comment for lp:~rodrigo-moya/ubuntuone-client/fix-657850

Revision history for this message
dobey (dobey) wrote :

We should avoid simply trapping all exceptions here, and this should probably have a test case, so that we can validate that it doesn't regress.

It should only trap an exception for the first two calls which you put inside the try:, and set exclusions = [] inside the except: I think.

review: Needs Fixing

« Back to merge proposal