Merge lp:~rodrigo-moya/ubuntuone-client/fix-640955 into lp:ubuntuone-client

Proposed by Rodrigo Moya
Status: Merged
Approved by: Rodrigo Moya
Approved revision: 710
Merged at revision: 711
Proposed branch: lp:~rodrigo-moya/ubuntuone-client/fix-640955
Merge into: lp:ubuntuone-client
Diff against target: 85 lines (+25/-6)
5 files modified
nautilus/add-contact-dialog.c (+5/-1)
nautilus/contacts-view.c (+5/-2)
nautilus/location-widget.c (+5/-1)
nautilus/share-dialog.c (+5/-1)
nautilus/u1-contacts-picker.c (+5/-1)
To merge this branch: bzr merge lp:~rodrigo-moya/ubuntuone-client/fix-640955
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Rick McBride (community) Approve
Review via email: mp+35807@code.launchpad.net

Commit message

Include glib's gi18n-lib.h, which forces definition of GETTEXT_PACKAGE

Description of the change

Include glib's gi18n-lib.h, which forces definition of GETTEXT_PACKAGE

To post a comment you must log in.
Revision history for this message
Rick McBride (rmcbride) wrote :

I get an error in make test with this branch (did not with the previous one)

===============================================================================
[ERROR]: tests.syncdaemon.test_eq_inotify.FreezeTests.test_rollback

Traceback (most recent call last):
Failure: twisted.internet.defer.TimeoutError: <tests.syncdaemon.test_eq_inotify.FreezeTests testMethod=test_rollback> (test_rollback) still running at 2.0 secs
-------------------------------------------------------------------------------

On a side note, we now have 1337 tests.

Which is aweseome.

review: Needs Fixing
Revision history for this message
Rick McBride (rmcbride) wrote :

retrying

review: Needs Information
Revision history for this message
Rick McBride (rmcbride) wrote :

does not recur. Approve

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

+1 works on mine too.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'nautilus/add-contact-dialog.c'
--- nautilus/add-contact-dialog.c 2010-06-02 14:44:08 +0000
+++ nautilus/add-contact-dialog.c 2010-09-17 12:08:43 +0000
@@ -20,7 +20,11 @@
20 */20 */
2121
22#include <string.h>22#include <string.h>
23#include <glib/gi18n.h>23#ifdef HAVE_CONFIG_H
24#include <config.h>
25#endif
26
27#include <glib/gi18n-lib.h>
24#include "add-contact-dialog.h"28#include "add-contact-dialog.h"
2529
26G_DEFINE_TYPE(AddContactDialog, add_contact_dialog, GTK_TYPE_DIALOG)30G_DEFINE_TYPE(AddContactDialog, add_contact_dialog, GTK_TYPE_DIALOG)
2731
=== modified file 'nautilus/contacts-view.c'
--- nautilus/contacts-view.c 2010-09-16 17:08:02 +0000
+++ nautilus/contacts-view.c 2010-09-17 12:08:43 +0000
@@ -19,8 +19,11 @@
19 * Boston, MA 02110-1301, USA.19 * Boston, MA 02110-1301, USA.
20 */20 */
2121
22#include "config.h"22#ifdef HAVE_CONFIG_H
23#include <glib/gi18n.h>23#include <config.h>
24#endif
25
26#include <glib/gi18n-lib.h>
24#include "contacts-view.h"27#include "contacts-view.h"
25#include "highlight.h"28#include "highlight.h"
2629
2730
=== modified file 'nautilus/location-widget.c'
--- nautilus/location-widget.c 2010-09-07 09:19:15 +0000
+++ nautilus/location-widget.c 2010-09-17 12:08:43 +0000
@@ -19,7 +19,11 @@
19 *19 *
20 */20 */
2121
22#include <glib/gi18n.h>22#ifdef HAVE_CONFIG_H
23#include <config.h>
24#endif
25
26#include <glib/gi18n-lib.h>
23#include <libsyncdaemon/syncdaemon-folders-interface.h>27#include <libsyncdaemon/syncdaemon-folders-interface.h>
24#include <libsyncdaemon/syncdaemon-shares-interface.h>28#include <libsyncdaemon/syncdaemon-shares-interface.h>
25#include "location-widget.h"29#include "location-widget.h"
2630
=== modified file 'nautilus/share-dialog.c'
--- nautilus/share-dialog.c 2010-08-02 10:40:26 +0000
+++ nautilus/share-dialog.c 2010-09-17 12:08:43 +0000
@@ -19,7 +19,11 @@
19 *19 *
20 */20 */
2121
22#include <glib/gi18n.h>22#ifdef HAVE_CONFIG_H
23#include <config.h>
24#endif
25
26#include <glib/gi18n-lib.h>
23#include <libsyncdaemon/libsyncdaemon.h>27#include <libsyncdaemon/libsyncdaemon.h>
24#include "share-dialog.h"28#include "share-dialog.h"
25#include "u1-contacts-picker.h"29#include "u1-contacts-picker.h"
2630
=== modified file 'nautilus/u1-contacts-picker.c'
--- nautilus/u1-contacts-picker.c 2010-07-08 17:17:59 +0000
+++ nautilus/u1-contacts-picker.c 2010-09-17 12:08:43 +0000
@@ -19,7 +19,11 @@
19 * Boston, MA 02110-1301, USA.19 * Boston, MA 02110-1301, USA.
20 */20 */
2121
22#include <glib/gi18n.h>22#ifdef HAVE_CONFIG_H
23#include <config.h>
24#endif
25
26#include <glib/gi18n-lib.h>
23#include "u1-contacts-picker.h"27#include "u1-contacts-picker.h"
24#include "add-contact-dialog.h"28#include "add-contact-dialog.h"
25#include "contacts-view.h"29#include "contacts-view.h"

Subscribers

People subscribed via source and target branches