Code review comment for lp:~rodrigo-moya/ubuntu/maverick/evolution/add-u1-email

> Even if this were to be split up into multiple patches (one to fix translation
> of e-mails, and another to add the U1 e-mail), in its current state, this
> would break the world for the default Inbox.
>
> 1) intltool does not support this format at all. Danilo stated he would be
> happy to add support for translating the e-mails to intltool, to make things
> easier, but it's not done yet. I also don't think this is the right way to do
> the translations via intltool. The small issues with intltool supporting
> multiple po directories need to be fixed first, so that these translations
> don't poison the regular strings, and inflate the resulting .mo files.
>
Danilo has already written a patch to do so, that's why the @intltool thing is used. We need that patch though in maverick before getting this in.

> 2) This patch is assuming that inlttool's desktop file translation mode
> supports this format, which it does not. The resulting e-mails will be invalid
> data, and the default messages will likely not show up at all.
>
again, Danilo's patch should support this

> 3) The method of translation for mbox files, should be to use the normal
> RFC822 message translation means in intltool, rather than a new oddball custom
> format.
>
I'll let Danilo comment on this, no idea

> 4) Evolution should be doing a bit more magic to generate the default Inbox
> file. Search and replace of a @DATETIME@ or similar variable, to insert the
> time at build, would be a huge improvement. It would also be nice if the
> resulting Inbox was merely a concatenation of individual mbox files, from a
> subdir. This would enable adding additional new, translatable, user messages
> easily. The translated messages could be output into subdirectories, and those
> messages could be concatenated into individual translated Inbox files for
> installation.
>
yes, that might be a good idea